Repository navigation
Split up config/panel.py - #489
Merged
Merged
Conversation
Aratz
marked this pull request as ready for review
October 6, 2026 11:55
Aratz
merged commit Oct 6, 2026
243ffe8
into
cursor/02-hashing-marker-id-helpers-e226
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
File
src/pixelator/pna/config/panel.pyhas become quite big. This PR splits it into smaller components to improve readability.Note
Low Risk
Mostly a move/refactor with re-exported symbols; behavior should match prior validation, now covered by additional targeted tests.
Overview
Replaces the monolithic
config/panel.pywith apixelator.pna.config.panelpackage (antibody_panel,diff,hashing,validation) while keeping the same public imports and APIs via__init__.py.Panel validation moves into
validation.pyas composable helpers (structure, types, uniqueness, UniProt, hashing rules). Structural failures still short-circuit before deeper checks; UniProt checking is slightly tidied with a shared regex helper.PNAAntibodyPanel.validate_antibody_panelnow delegates to that module instead of inlining the logic.Adds unit tests that exercise individual validation error paths (missing columns, empty panel, index, duplicate sequences, control dtype, column types).
Reviewed by Cursor Bugbot for commit 4b7b5c2. Bugbot is set up for automated code reviews on this repo. Configure here.