Update CSV adapter - #748
Open
AndrewSasmito wants to merge 13 commits into
Open
Conversation
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com> Refactor CsvInputAdapterManager for improved clarity Add new fields and methods to CsvInputAdapterManager Fix error
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
AndrewSasmito
requested review from
AdamGlustein,
alexddobkin,
arhamchopra,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
August 13, 2026 05:10
timkpaine
requested changes
Aug 13, 2026
|
|
||
| - **line 3**: this is where the instance of an adapter *--impl--* registers itself with the `CSVReaderImpl`. | ||
| - **line 6+**: this is where we define `CSVReadAdapter`, the *--graph--* time representation of a CSV adapter, returned from `CSVReader.subscribe` | ||
| TODO |
Member
There was a problem hiding this comment.
We definitely want to keep an example of this
Contributor
Author
There was a problem hiding this comment.
For sure, I will try rewriting the docs right before we merge in case changes are made during review (which might require another rewrite).
robambalu
reviewed
Aug 13, 2026
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
robambalu
marked this pull request as draft
August 14, 2026 15:06
timkpaine
added
type: feature
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
AndrewSasmito
force-pushed
the
csv-adapter
branch
2 times, most recently
from
August 17, 2026 00:47
89ead06 to
33774fc
Compare
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
AndrewSasmito
force-pushed
the
csv-adapter
branch
from
August 17, 2026 01:16
33774fc to
aa24b88
Compare
AndrewSasmito
marked this pull request as ready for review
August 17, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259.
Summary
Rewrite the CSV adapter to use a C++ engine rather than pure Python. This new implementation also allows the 'symbol_column' parameter to be optional, allowing for greater flexibility than the original implementation.
Limitations
Initial current implementation is with basic C++, hopefully we can do the following: