Add Sword/Shield encounters (Part 3: Southern Wild Areas)#1577
Open
jemarq04 wants to merge 14 commits into
Open
Add Sword/Shield encounters (Part 3: Southern Wild Areas)#1577jemarq04 wants to merge 14 commits into
jemarq04 wants to merge 14 commits into
Conversation
…d its location area prose
…not change level after beating the game
Naramsim
approved these changes
Jun 30, 2026
| @@ -0,0 +1,272 @@ | |||
| #!/usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
The continuation of PR #1550 and #1564, addressing issue #1459. I've reviewed each of the location areas as I usually do for encounter PRs that I review formally to try and catch as many mistakes as possible.
This PR adds encounters for all needed conditions (weather and before/after beating the game) in the southern wild areas in Galar. Missing prose was added for each location area that gained encounters. Only one location area was renamed (from
south-lake-miloch-2tosouth-lake-miloch-area-2to match Serebii).Additionally, I added a script I've cobbled together over time to help review encounter information. I figure that sharing it can help anyone wanting to work on these contributions, and I hadn't noticed the scripts directory until recently. I cleaned it up and added comments to make it understandable - it uses
argparseso running it with-hor--helpwill explain the arguments.I'll be working on the rest of the wild areas next, then on the DLC version split in the API.
AI coding assistance disclosure
No AI was used.
Contributor check list