Skip to content

Add Sword/Shield encounters (Part 3: Southern Wild Areas)#1577

Open
jemarq04 wants to merge 14 commits into
PokeAPI:masterfrom
jemarq04:feat/add-swsh-wild-areas
Open

Add Sword/Shield encounters (Part 3: Southern Wild Areas)#1577
jemarq04 wants to merge 14 commits into
PokeAPI:masterfrom
jemarq04:feat/add-swsh-wild-areas

Conversation

@jemarq04

Copy link
Copy Markdown
Member

Change description

The continuation of PR #1550 and #1564, addressing issue #1459. I've reviewed each of the location areas as I usually do for encounter PRs that I review formally to try and catch as many mistakes as possible.

This PR adds encounters for all needed conditions (weather and before/after beating the game) in the southern wild areas in Galar. Missing prose was added for each location area that gained encounters. Only one location area was renamed (from south-lake-miloch-2 to south-lake-miloch-area-2 to match Serebii).

Additionally, I added a script I've cobbled together over time to help review encounter information. I figure that sharing it can help anyone wanting to work on these contributions, and I hadn't noticed the scripts directory until recently. I cleaned it up and added comments to make it understandable - it uses argparse so running it with -h or --help will explain the arguments.

I'll be working on the rest of the wild areas next, then on the DLC version split in the API.

AI coding assistance disclosure

No AI was used.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@@ -0,0 +1,272 @@
#!/usr/bin/env python3

@Naramsim Naramsim Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with your name and ID?

@jemarq04 (37006684)

So we know who is behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants