replfwd.conf: mimick the logic from wforce.conf - #498
Merged
Conversation
- Replace the webserver call by addListener
- Replace the setKey() by --SETKEY
- Add the setWebserverPassword("--WEBPWD") call
- Also, use a different port, to allow concurrent runs by default
Collaborator
|
Thanks, yes this looks like an oversight indeed. Not sure it will fail to install, but it certainly isn't correct as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @neilcook
Before offering debian/ packaging patches as discussed in #462 , I decided to package your latest version of weakforced to be actual.
replfwd.conf doesn't follow the logic of the wforce.conf file, and I guess it might actually fail to install properly from the postinst you drafted in your debian packaging system as neither SETKEY or WEBPWD are there.
Also, the default config clashes with the wforce config on the port.
Therefore, I offer this commit with these changes
If you're interested in, be my guest, otherwise I'll tag my patch as debian-specific in debian source package.