Skip to content

fix: fix gpu scheduler policy sort bug(#1806) #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaiiyvwu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix gpu scheduler policy sort bug(#1806) #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7335b13
fix: fix gpu scheduler policy sort bug(#1806)
kaiiyvwu Apr 27, 2026
22e88df
fix: fix gpu scheduler policy sort bug(#1806)
kaiiyvwu Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/scheduler/policy/gpu_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@ func (l DeviceUsageList) Swap(i, j int) {
}

func (l DeviceUsageList) Less(i, j int) bool {
if l.Policy == util.GPUSchedulerPolicyBinpack.String() {
switch l.Policy {
case util.GPUSchedulerPolicyBinpack.String():
return l.DeviceLists[i].Score < l.DeviceLists[j].Score
case util.GPUSchedulerPolicySpread.String():
return l.DeviceLists[i].Score > l.DeviceLists[j].Score
default:

@mesutoezdil mesutoezdil Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default branch has no test. add a case with a non-binpack, non-spread policy (e.g. empty string or "topology") and devices on different numa nodes to cover the two return paths here.

if l.DeviceLists[i].Device.Numa == l.DeviceLists[j].Device.Numa {
return l.DeviceLists[i].Score < l.DeviceLists[j].Score
return l.DeviceLists[i].Score > l.DeviceLists[j].Score
}
return l.DeviceLists[i].Device.Numa > l.DeviceLists[j].Device.Numa
}
// default policy is spread
if l.DeviceLists[i].Device.Numa == l.DeviceLists[j].Device.Numa {
return l.DeviceLists[i].Score > l.DeviceLists[j].Score
return l.DeviceLists[i].Device.Numa < l.DeviceLists[j].Device.Numa
}
return l.DeviceLists[i].Device.Numa < l.DeviceLists[j].Device.Numa
}

func (ds *DeviceListsScore) ComputeScore(requests device.ContainerDeviceRequests) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/scheduler/policy/gpu_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func TestDeviceUsageList_Less(t *testing.T) {
{Device: &device.DeviceUsage{Numa: 0, Used: 10}, Score: 10},
{Device: &device.DeviceUsage{Numa: 1, Used: 20}, Score: 20},
},
expectedLess: false,
expectedLess: true,
},
{
name: "Spread policy with same Numa",
Expand All @@ -177,7 +177,7 @@ func TestDeviceUsageList_Less(t *testing.T) {
{Device: &device.DeviceUsage{Numa: 0, Used: 10}, Score: 10},
{Device: &device.DeviceUsage{Numa: 1, Used: 20}, Score: 20},
},
expectedLess: true,
expectedLess: false,
},
}

Expand Down
Loading