Skip to content

feat(scheduler): add GPU-aware PreemptVerb victim refinement #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maishivamhoo123 wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat(scheduler): add GPU-aware PreemptVerb victim refinement #1924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dec58ea
feat(scheduler): add GPU-aware PreemptVerb victim refinement
maishivamhoo123 Jun 4, 2026
db3d7fa
Added all the Gemini review and improve the code patch percentage
maishivamhoo123 Jun 4, 2026
e3331e2
E2e Test case handeling the helmchart
maishivamhoo123 Jun 4, 2026
40be567
Merge branch 'master' into feat/preemptverb-gpu-aware-victim-refinement
maishivamhoo123 Jun 4, 2026
f9d714d
E2e test failing
maishivamhoo123 Jun 4, 2026
a56fd67
fixed the e2e failure
maishivamhoo123 Jun 4, 2026
c4d9e43
Added all the suggested changes
maishivamhoo123 Jun 4, 2026
035aba7
Added all the Recommended changes
maishivamhoo123 Jun 5, 2026
5ad8fcd
Linting fixed
maishivamhoo123 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/hami/templates/scheduler/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ data:
{{- end }}
filterVerb: filter
bindVerb: bind
preemptVerb: preempt
nodeCacheCapable: true
weight: 1
httpTimeout: 30s
Expand All @@ -61,6 +62,7 @@ data:
{{- end }}
"filterVerb": "filter",
"bindVerb": "bind",
"preemptVerb": "preempt",
"weight": 1,
"nodeCacheCapable": true,
"httpTimeout": 30000000000,
Expand Down
9 changes: 8 additions & 1 deletion cmd/scheduler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/Project-HAMi/HAMi/pkg/device"
"github.com/Project-HAMi/HAMi/pkg/scheduler"
"github.com/Project-HAMi/HAMi/pkg/scheduler/config"
"github.com/Project-HAMi/HAMi/pkg/scheduler/preempt"
"github.com/Project-HAMi/HAMi/pkg/scheduler/routes"
"github.com/Project-HAMi/HAMi/pkg/util"
"github.com/Project-HAMi/HAMi/pkg/util/client"
Expand All @@ -45,6 +46,7 @@ import (

var (
sher *scheduler.Scheduler
vgpu *preempt.VgpuPreempt
tlsKeyFile string
tlsCertFile string
enableProfiling bool
Expand Down Expand Up @@ -139,6 +141,10 @@ func start() error {
return err
}
defer sher.Stop()
vgpu, err = preempt.New(sher.GetInformerFactory(), sher.GetEventRecorder())
if err != nil {
return fmt.Errorf("failed to initialize vgpu preemptor: %w", err)
}

// start monitor metrics
go initMetrics(config.MetricsBindAddress, legacyMetrics)
Expand All @@ -150,8 +156,9 @@ func start() error {
router.POST("/webhook", routes.WebHookRoute())
router.GET("/healthz", routes.HealthzRoute())
router.GET("/readyz", routes.ReadyzRoute(sher))
klog.Info("listen on ", config.HTTPBind)
router.POST("/preempt", routes.PreemptRoute(vgpu))

klog.Info("listen on ", config.HTTPBind)
if enableProfiling {
injectProfilingRoute(router)
klog.Infof("Profiling enabled, visit %s/debug/pprof/ to view profiles", config.HTTPBind)
Expand Down
Loading
Loading