Fix indentations and consistency in benchmark.md#557
Conversation
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughBenchmark documentation was updated in the English guide and two Chinese localized guides. The changes adjust test-instance wording to “Kubernetes + …” and reformat benchmark reproduction commands into fenced bash blocks with multiline report invocation. ChangesBenchmark documentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
cI is failing: run npm run format, the table columns are misaligned after the text changes and "Docker version 29.4.0" --> "v29.4.0" looks wrong?, Docker does not use a v prefix. This was also not applied to versioned_docs/version-v2.9.0/userguide/benchmark.md, so English and Chinese v2.9.0 now disagree pls drop the v prefix or apply it there too |
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
|
/lgtm |
1-2-3listSummary by CodeRabbit
opensource version v280andopensource version v290.bashcode blocks and adjusted the step numbering/structure for consistency across language versions.