Add headers - #46
Merged
Merged
Conversation
Set User-Agent: aleo-python-sdk/<version> on all SDK requests — reads, JWT refresh, the prover handshake, and every scanner call — so the SDK is identifiable in standard access logs (overriding the python-requests/httpx default). Injected at the two per-request header layers (network client's method_headers and the scanner's _build_headers, sync + async, including their JWT-refresh sub-requests). Registered in SDK_HEADERS so it's suppressed when the caller supplies their own transport, matching the existing x-aleo-* headers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
iamalwaysuncomfortable
changed the title
Drop "user-agent" from SDK_HEADERS. The UA is only ever added on the default transport (in method_headers' non-custom branch), so it was never present to "suppress" under a custom transport — the only effect of the SDK_HEADERS entry was to delete a User-Agent the CALLER set, which is the opposite of hands-off. With a custom transport the SDK now layers nothing of its own; the caller's headers pass through untouched. Adds a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kpandl
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header management.