[Feature] Add UnknownReason for disconnects - #4018
Merged
Merged
Conversation
kaimast
changed the title
Unknown disconnecUnknownReason for disconnects
kaimast
force-pushed
the
feat/disconnect-reason
branch
4 times, most recently
from
November 20, 2025 21:16
83b5be9 to
d91b590
Compare
kaimast
force-pushed
the
feat/disconnect-reason
branch
from
November 21, 2025 18:36
d91b590 to
4027d70
Compare
kaimast
marked this pull request as ready for review
November 21, 2025 23:49
ljedrz
reviewed
Nov 24, 2025
ljedrz
reviewed
Nov 24, 2025
ljedrz
reviewed
Nov 24, 2025
Co-authored-by: ljedrz <3750347+ljedrz@users.noreply.github.com> Signed-off-by: Kai Mast <kai@kaimast.com>
raychu86
reviewed
Nov 25, 2025
raychu86
reviewed
Nov 25, 2025
Co-authored-by: Raymond Chu <14917648+raychu86@users.noreply.github.com> Signed-off-by: Kai Mast <kai@kaimast.com>
Contributor
Author
|
Typos fixed! |
ljedrz
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure forward compatibility with new disconnect reasons, such as the ones in #3902, this PR adds an
UnknownReasonthat is the defaultDisconnectReasonwhen encountering and unknown value.This is useful, as adding a new disconnect reason should not require a message version bump or a synchronous update.
Additionally, the PR implements
DisplayforDisconnectReasonand uses it in log/error messages (in 4027d70)