Use transaction compute spend helper - #4348
Open
eranrund wants to merge 1 commit into
Open
Conversation
| Transaction::Execute(_, _, execution, _) => { | ||
| let (_, cost_details) = execution_cost(self.ledger.vm().process(), execution, consensus_version)?; | ||
| let compute_spend = execute_compute_cost_in_microcredits(cost_details, consensus_version); | ||
| if consensus_version >= ConsensusVersion::V11 { |
Collaborator
There was a problem hiding this comment.
Is this consensus version gate still active with this refactor? Does transaction_compute_spend_in_microcredits exhibit the same behavior?
Collaborator
There was a problem hiding this comment.
Even if it isn't, it would be harmless to remove it as the network is already past that consensus version.
vicsn
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DRYing things up, see #4253
Test Plan
Relying on existing tests.
Documentation
N/A
Backwards compatibility
Logic should be identical so no backwards compatibility issues expected.