fix(tests): omit concrete outputs from rewritten expectations - #3342
Open
sethryanrollins wants to merge 2 commits into
Open
fix(tests): omit concrete outputs from rewritten expectations#3342sethryanrollins wants to merge 2 commits into
sethryanrollins wants to merge 2 commits into
Conversation
vicsn
reviewed
Jul 30, 2026
vicsn
left a comment
vicsn
left a comment
Collaborator
There was a problem hiding this comment.
Mostly LGTM! Thank you! Can you resolve the merge conflict with staging?
Author
|
@vicsn can do! Should be able to when I get into work in a few |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
REWRITE_EXPECTATIONSto leave out the concrete output values that the tests no longer compare. Those values can change because of randomness, causing noisy expectation diffs. The existing expectation files were regenerated without the unused additional output data, and tests were added to cover the rewrite behavior. Closes #3341.