Make synthesis limit tracking robust against function calls - #3344
Open
vicsn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our synthesis limit tracking was not robust in the presence of function calls (which reset limits).
Test Plan
Appropriate unit tests were added.
Backwards compatibility
This PR changes transaction validity and should therefore technically be
ConsensusVersionguarded. However, the change lives deep in the VM logic which is supposed to be stateless, which makes this quite hard to do.[1] Fortunately, only explicitly maliciously crafted transactions become invalid, which has a low probability of happening in practice at the moment so IMO we can forego this effort.[1] In
fn verify_deployment, we would have to set artifically high synthesis limits, and then build out a newexecutepipeline to perform a synthesis limit check just until the first function call.