-
Notifications
You must be signed in to change notification settings - Fork 131
improve model debugging workflow #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ethernet8023
wants to merge
8
commits into
main
Choose a base branch
from
train-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
92f93c5
refactor: move Data Server Config type into data-provider crate
ethernet8023 5886929
client: introduce a non-Display impl for LLMArchitecture to convert t…
ethernet8023 d125dd4
fix: typo in run-manager readme
ethernet8023 7549ad6
nix: add cargo-all-features to devShell
ethernet8023 bd48aa3
feat: add regular config + data providers to train binary + tiny script
ethernet8023 350afd8
feat: add `dump-config` to run-manager
ethernet8023 ad5b5ad
refactor: remove unused Result from HttpDataProvider::new return type
ethernet8023 2be4669
modeling: work around noexec tmp dirs for triton cache
ethernet8023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,7 @@ | |
| cargo-watch | ||
| cargo-expand | ||
| cargo-nextest | ||
| cargo-all-features | ||
|
|
||
| self'.packages.solana-toolbox-cli | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ## make-tiny-init reference | ||
|
|
||
| The `make-tiny-init.py` script creates tiny versions of any psyche/hf/torchtitan-compatible model for fast iteration. It produces a tiny init checkpoint, a `config.json`, and a ready-to-use [run config](../enduser/run-config.md). | ||
|
|
||
| ### Model Input | ||
|
|
||
| The script accepts one of the following model formats: | ||
|
|
||
| ```bash | ||
| # HF repo slug: easiest way, downloads config + tokenizer | ||
| nix develop .#python --command python scripts/make-tiny-init.py --repo Qwen/Qwen3-30B-A3B --save /tmp/test-qwen | ||
|
|
||
| # from a raw HF config.json, use --tokenizer to include a tokenizer | ||
| nix develop .#python --command python scripts/make-tiny-init.py --config /path/to/config.json --save /tmp/tiny --tokenizer Qwen/Qwen3-30B-A3B | ||
|
|
||
| # from a torchtitan job toml | ||
| nix develop .#python --command python scripts/make-tiny-init.py --toml /path/to/train.toml --save /tmp/tiny-run | ||
|
|
||
| # from a psyche run config (reads model.LLM.checkpoint.Hub.repo_id) | ||
| nix develop .#python --command python scripts/make-tiny-init.py --psyche /path/to/state.toml --save /tmp/tiny-llama | ||
| ``` | ||
|
|
||
| Read the comments inside the make-tiny-init script for more information. | ||
|
|
||
| > **Tip:** use `--preserve vocab_size` if you want to train on real tokenized data — otherwise the tiny vocab won't match your tokenizer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean exactly? and is it torchtitan format or safetensors or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's for if you're adding a new model architecture - it's just "implement your model architecture in our torch titan fork". new model shapes in existing architectures don't need anything fancy like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh ok I see ty