Skip to content

Mirror error logs to stderr in TUI mode #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bornoz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mirror error logs to stderr in TUI mode #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions shared/tui/src/logging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use ratatui::{
widgets::{Block, Widget},
};
use tracing::Level;
use tracing_subscriber::{EnvFilter, Layer, filter::FromEnvError, fmt};
use tracing_subscriber::{EnvFilter, Layer, filter::FromEnvError, filter::LevelFilter, fmt};
use tui_logger::{TuiLoggerLevelOutput, TuiLoggerWidget, TuiWidgetEvent, TuiWidgetState};

#[derive(Clone, Debug, Copy, ValueEnum, PartialEq)]
Expand Down Expand Up @@ -572,11 +572,23 @@ fn init_logging_core(

// add output layer
match output {
LogOutput::TUI => layers.push(
tui_logger::tracing_subscriber_layer()
.with_filter(output_logs_filter)
.boxed(),
),
LogOutput::TUI => {
layers.push(
tui_logger::tracing_subscriber_layer()
.with_filter(output_logs_filter)
.boxed(),
);
// The TUI log widget is torn down with the alternate screen on exit
// or panic, taking its contents with it. Mirror error-level events
// to stderr as well, so a failure is still readable in the terminal
// once the TUI is gone.
layers.push(
fmt::layer()
.with_writer(std::io::stderr)
.with_filter(LevelFilter::ERROR)
.boxed(),
);
}
LogOutput::TUIAndConsole => {
layers.push(
tui_logger::tracing_subscriber_layer()
Expand Down