docs(book): fix wrong WALLET_PATH env var and small typos - #657
Open
Sahilvishnaliya wants to merge 1 commit into
Open
docs(book): fix wrong WALLET_PATH env var and small typos#657Sahilvishnaliya wants to merge 1 commit into
Sahilvishnaliya wants to merge 1 commit into
Conversation
The joining-a-run quickstart documented WALLET_PATH in the .env example, but run-manager only reads RAW_WALLET_PRIVATE_KEY or WALLET_PRIVATE_KEY_PATH (load_wallet_key in run-manager lib.rs), so following the doc verbatim fails with 'No wallet private key!'. Also fixes: 'exiting' -> 'existing' in the intro, a broken sentence in the nix binary-cache section of setup, and a stray 'and' in the TCP data-provider notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
un-manager\ only reads \RAW_WALLET_PRIVATE_KEY\ or \WALLET_PRIVATE_KEY_PATH\ (see \load_wallet_key\ in \ ools/rust-tools/run-manager/src/lib.rs), so the documented \WALLET_PATH\ variable was silently unused and following the guide verbatim fails with \No wallet private key!. The quickstart-compute-provider page already used the correct variable; this brings the two pages in sync.
Link-only + typo fixes; no prose restructuring.