Repository navigation
fix: Add Configurable Alerting for Campaign Budget Thresholds - #1320
Closed
Teejay2696 wants to merge 1 commit into
Closed
Teejay2696 wants to merge 1 commit into
Teejay2696 wants to merge 1 commit into
Conversation
|
@Teejay2696 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Teejay2696
marked this pull request as ready for review
September 29, 2026 09:06
Teejay2696
force-pushed
the
solver/issue-1187-86-a0
branch
from
October 6, 2026 17:50
bdd9f64 to
127c20e
Compare
Contributor
|
Doing a repo-wide cleanup - closing all currently open pull requests to reset the board, not a judgement on this contribution. Nothing is lost: this branch and every commit on it still exist, and you're welcome to reopen this PR (or open a fresh one) at any time. If this was tracking an issue, that issue is being unassigned so it goes back into the open pool - feel free to comment on it to pick the work back up. Thanks for contributing to Soter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented configurable alerting for campaign budget thresholds via a scheduled cron job (CampaignBudgetAlertScheduler) that checks campaign budget consumption against configurable thresholds (defaulting to 80%), sends notifications to admins, and deduplicates alerts using audit logs.
Changed files
app/backend/src/campaigns/campaign-budget-alert.scheduler.tsTest plan
Run backend tests including unit tests for the campaign budget alert scheduler covering threshold crossing and de-duplication.
This PR was created as a draft by the issue solver bot. It will remain a
draft until repository CI passes.
Closes #1187