Repository navigation
Fix unused variable removal for keyword arguments - #374
Open
Sanjays2402 wants to merge 1 commit into
Open
Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372.
An assignment such as
user = User.objects.get(id=id)was left unchanged because the removal logic counted every=character as an assignment. Parse the statement to recognize a single name target, then preserve the original expression when removing the unused binding. Chained assignments, unpacking, attribute/subscript assignments, and multiline statements remain unchanged.With
--remove-rhs-for-unused-variables, insert a temporarypassso removing the only statement leaves valid Python; the existing cleanup removes that placeholder when another statement remains.Validation: all 182 tests in
test_autoflake.pypassed, including 11 subtests; new regressions failed against unchanged main. The pinned Ty type check, Ruff checks/formatting and the project's fuzz script on both changed Python files passed. Prepared with Codex.