Skip to content

[WIP] Update docker tests to future postgres postgis versions#200

Open
ponceta wants to merge 8 commits into
masterfrom
poa_update_ci_parameter
Open

[WIP] Update docker tests to future postgres postgis versions#200
ponceta wants to merge 8 commits into
masterfrom
poa_update_ci_parameter

Conversation

@ponceta

@ponceta ponceta commented Feb 23, 2023

Copy link
Copy Markdown
Member

Update docker tests to actual postgres postgis versions

Use ubuntu LTS check old postgres postgis, soon to be old, recent and newest

Update docker tests to actual postgres postgis versions
@ponceta ponceta self-assigned this Feb 23, 2023
Adjust docker image tags
@ponceta ponceta closed this Feb 24, 2023
@ponceta ponceta reopened this Feb 24, 2023
@olivierdalang

Copy link
Copy Markdown
Contributor

Which release does this PR target ? We have no defined policy for 1.x.x, but in the future, dropping support for postgres versions changes would have to be frozen for the next yearly release, so IMO we should already apply this policy and freeze that for 2023.0.

@ponceta

ponceta commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

@olivierdalang I was only checking automated tests and CI options but the goal is to change that for the 2023.0 Release once the 1.6.0 step is finished. Release policy is in what we discussed a part of 2023 release.

TEKSI modules - Features and bugs Roadmap (view)

Remove postgis 2.5 since it isn't supported by the CI already
Test actions/checkout@v3
Upgade Dockerfile to LTR
@ponceta

ponceta commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

Fix warnings on deprecated libraries and actions :

image

@ponceta ponceta changed the title Update docker tests to actual postgres postgis versions [WIP] Update docker tests to actual postgres postgis versions Feb 24, 2023
@ponceta ponceta added the sustainability Provides a sustainability or maintenance improvement label Feb 28, 2023
@olivierdalang olivierdalang added this to the 2023.0 milestone Mar 9, 2023
@ponceta ponceta changed the title [WIP] Update docker tests to actual postgres postgis versions [WIP] Update docker tests to future postgres postgis versions Jul 17, 2023
@ponceta ponceta closed this Mar 13, 2024
@ponceta ponceta reopened this Mar 13, 2024
@ponceta

ponceta commented Mar 13, 2024

Copy link
Copy Markdown
Member Author

@3nids it looks like 3.2 and 3.4 have been fixed but not 3.3, any hint / good practices on how to prevent users from using it?

@3nids

3nids commented Mar 13, 2024

Copy link
Copy Markdown
Member

good question, the simplest is probably in the SQL install script to detect SELECT PostGIS_full_version() and raise an error.

@sjib

sjib commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

@ponceta Is this still wanted? If yes can you make it 1.6.2 ready

@ponceta

ponceta commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Postgis 3.3 docker image has not been updated so it is not fixed, postgis 3.2 is available on postgres 14-3.2 but is already two years old.

@ponceta

ponceta commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

system_user now looks like a reserved keyword, we have to adapt it to support postgres 16.

@ponceta

ponceta commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

@sjib here is the full error log if required for postgres 16

psql:/src/03_qgep_db_dss.sql:175: ERROR:  syntax error at or near "system_user"
LINE 1: ALTER TABLE qgep_od.mutation ADD COLUMN system_user  varchar...

@ponceta ponceta closed this Aug 29, 2024
@ponceta ponceta reopened this Aug 29, 2024
@sjib

sjib commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

#238 should help to solve this.

@sjib

sjib commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@ponceta Still an issue? Do you want this also fixed with the next release? Then please add to milestone 1.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sustainability Provides a sustainability or maintenance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants