Add qubits and clbits to dag in DAGCircuit::with_capacity#13090
Closed
ElePT wants to merge 1 commit into
Closed
Conversation
Collaborator
|
One or more of the following people are relevant to this code:
|
Contributor
Author
|
Closing after internal discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #13002 that adds qubits and clbits to the dag when
num_qubitsornum_clbitsare non-zero. This would enable, for example, directly appending instructions using an iterator (#13032) after creating a new rustDAGCircuit. The alternative is making users add the qubits/clbits manually.I don't think this is 100% necessary but it definitely increases the usability of
with_capacity, in fact, this is how it's done inCircuitData(L238-251).Details and comments