fix(review): strip ANSI from gh JSON output - #10249
Draft
AaronZ345 wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Qwen precheck requires maintainer approval before automated triage/review. Head SHA: Reason:
A maintainer with write access can inspect the PR and manually request a run with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh apiJSON output before parsing.Root Cause
When
ghemits colorized output, JSON parsing in the review helpers can fail because the raw payload contains ANSI control sequences. This can break review automation even though the underlying GitHub API response is valid JSON.Fixes #10241.
Test Plan
npm run test --workspace packages/cli -- src/commands/review/lib/gh.test.ts --pool threads --maxWorkers 1npx prettier --check packages/cli/src/commands/review/lib/gh.ts packages/cli/src/commands/review/lib/gh.test.ts