Skip to content

fix(review): warn on self-targeted asset publishing - #10251

Draft
AaronZ345 wants to merge 2 commits into
QwenLM:mainfrom
AaronZ345:fix/10239-publish-assets-self-guard
Draft

fix(review): warn on self-targeted asset publishing#10251
AaronZ345 wants to merge 2 commits into
QwenLM:mainfrom
AaronZ345:fix/10239-publish-assets-self-guard

Conversation

@AaronZ345

Copy link
Copy Markdown
Contributor

Summary

  • Add a best-effort self-targeting warning for qwen review publish-assets when QWEN_REVIEW_ASSETS_REPO resolves to the reviewed repository.
  • Resolve the reviewed repository from --reviewed-repo when available, otherwise from gh repo view, preserving fork-parent behavior.
  • Cover the case-insensitive self-target warning path with a regression test.

Root Cause

The automated review lanes stopped publishing evidence into the repository under review, but the user-invoked publish-assets command still accepted stale local QWEN_REVIEW_ASSETS_REPO=<repo-under-review> settings without any signal. That could keep creating pr-assets/* refs in the reviewed repository.

Fixes #10239.

Test Plan

  • npm run test --workspace packages/cli -- src/commands/review/publish-assets.test.ts --pool threads --maxWorkers 1
  • npx prettier --check packages/cli/src/commands/review/publish-assets.ts packages/cli/src/commands/review/publish-assets.test.ts

Notes

zhangyu.34 and others added 2 commits August 27, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

follow-up(cli): publish-assets has no self-targeting guard for local runs (from #9985)

2 participants