fix(review): warn on self-targeted asset publishing - #10251
Draft
AaronZ345 wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qwen review publish-assetswhenQWEN_REVIEW_ASSETS_REPOresolves to the reviewed repository.--reviewed-repowhen available, otherwise fromgh repo view, preserving fork-parent behavior.Root Cause
The automated review lanes stopped publishing evidence into the repository under review, but the user-invoked
publish-assetscommand still accepted stale localQWEN_REVIEW_ASSETS_REPO=<repo-under-review>settings without any signal. That could keep creatingpr-assets/*refs in the reviewed repository.Fixes #10239.
Test Plan
npm run test --workspace packages/cli -- src/commands/review/publish-assets.test.ts --pool threads --maxWorkers 1npx prettier --check packages/cli/src/commands/review/publish-assets.ts packages/cli/src/commands/review/publish-assets.test.tsNotes
npm run buildis currently blocked in this worktree by the pre-existingpackages/core/src/core/client.telemetrySwap.test.tsduplicate-property TypeScript error tracked separately in fix(core): remove duplicate telemetry test registry stub #10243.