fix(cli): swallow synchronous goal-persistence throws at the startup gate (#10298)

packages/cli/src/ui/utils/goal-runtime.test.ts

@@ -28,16 +28,22 @@ describe('waitForGoalRuntime', () => {
     expect(getGoalRuntimeReady).toHaveBeenCalledTimes(1);
   });
 
-  it('does not hide malformed or unsupported persisted Goal state', async () => {
-    const failure = new Error('unsupported Goal lifecycle record');
-    const getGoalRuntimeReady = vi.fn().mockRejectedValue(failure);
+  // Config.getGoalRuntimeReady() throws synchronously (not a rejected
+  // promise) when persistence is unavailable; the gate must swallow that
+  // shape too or it escapes the startup effect as an unhandled rejection
+  // and the TUI never leaves its init banner (#10272).
+  it('allows Goal-less sessions when readiness throws synchronously', async () => {
+    const getGoalRuntimeReady = vi.fn((): Promise<GoalRuntime> => {
+      throw new GoalPersistenceUnavailableError();
+    });
 
-    await expect(waitForGoalRuntime({ getGoalRuntimeReady })).rejects.toBe(
-      failure,
+    await expect(waitForGoalRuntime({ getGoalRuntimeReady })).resolves.toBe(
+      true,
     );
+    expect(getGoalRuntimeReady).toHaveBeenCalledTimes(1);
   });
 
-  it('allows Goal-less sessions when readiness throws synchronously', async () => {
+  it('swallows a synchronous readiness throw inside the bounded wait too', async () => {
     const getGoalRuntimeReady = vi.fn((): Promise<GoalRuntime> => {
       throw new GoalPersistenceUnavailableError();
     });
@@ -47,6 +53,15 @@ describe('waitForGoalRuntime', () => {
     ).resolves.toBe(true);
   });
 
+  it('does not hide malformed or unsupported persisted Goal state', async () => {
+    const failure = new Error('unsupported Goal lifecycle record');
+    const getGoalRuntimeReady = vi.fn().mockRejectedValue(failure);
+
+    await expect(waitForGoalRuntime({ getGoalRuntimeReady })).rejects.toBe(
+      failure,
+    );
+  });
+
   it('does not hide synchronous readiness errors', async () => {
     const failure = new Error('unsupported Goal lifecycle record');
     const getGoalRuntimeReady = vi.fn((): Promise<GoalRuntime> => {

packages/cli/src/ui/utils/goal-runtime.ts

@@ -56,6 +56,10 @@ export async function waitForGoalRuntime(
 ): Promise<boolean> {
   const awaitReady = async (): Promise<void> => {
     try {
+      // The call must stay inside the try: Config.getGoalRuntimeReady()
+      // THROWS synchronously (rather than returning a rejected promise)
+      // when persistence is unavailable, and escaping the catch turned it
+      // into an unhandled rejection that killed the startup effect.
       await config.getGoalRuntimeReady();
     } catch (error) {
       if (!(error instanceof GoalPersistenceUnavailableError)) throw error;

packages/core/src/agents/team/teamHelpers.test.ts

@@ -53,9 +53,7 @@ vi.mock('../../config/storage.js', async (importOriginal) => {
 // otherwise the real readFile runs.
 vi.mock('node:fs/promises', async (importOriginal) => {
   const actual = await importOriginal<typeof import('node:fs/promises')>();
-  type ReadFileHook = (
-    ...args: Parameters<typeof actual.readFile>
-  ) => unknown;
+  type ReadFileHook = (...args: Parameters<typeof actual.readFile>) => unknown;
   let readFileHook: ReadFileHook | undefined;
   return {
     ...actual,