Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
1273926
Add hipDNN to TheRock
BrianHarrisonAMD Oct 3, 2025
dcd5026
Merge branch 'main' into users/bharriso/add-hipdnn
SamuelReeder Oct 7, 2025
a2c3c99
Merge branch 'main' into users/bharriso/add-hipdnn
BrianHarrisonAMD Oct 8, 2025
52b1b45
add hipDNN flag to documentation
BrianHarrisonAMD Oct 8, 2025
21eb0f0
Update TheRock tests for hipDNN
BrianHarrisonAMD Oct 10, 2025
ef89608
Fix path for testing artifacts
BrianHarrisonAMD Oct 13, 2025
faf0a86
Merge branch 'main' into users/bharriso/add-hipdnn
BrianHarrisonAMD Oct 16, 2025
f7083bd
Add miopen-plugin project to TheRock
BrianHarrisonAMD Oct 16, 2025
f22a54e
Remove unneccessarry build flags
BrianHarrisonAMD Oct 16, 2025
00c77a9
add hipDNN to Windows support subprojects
BrianHarrisonAMD Oct 17, 2025
e31a80e
Fix arg name
BrianHarrisonAMD Oct 17, 2025
01751bf
Update args for fetch script
BrianHarrisonAMD Oct 17, 2025
ad27ec9
Merge branch 'main' into users/bharriso/add-hipdnn
BrianHarrisonAMD Oct 17, 2025
8ae5c16
Merge branch 'users/bharriso/add-hipdnn' into users/bharriso/add-miop…
BrianHarrisonAMD Oct 17, 2025
aca0ff8
Update CMakeLists.txt
BrianHarrisonAMD Oct 17, 2025
9c00f50
Merge branch 'users/bharriso/add-hipdnn' into users/bharriso/add-miop…
BrianHarrisonAMD Oct 17, 2025
4ed1ad0
Add note to track hipDNN windows support issue
BrianHarrisonAMD Oct 17, 2025
c7f149a
Merge remote-tracking branch 'origin/main' into users/bharriso/add-hi…
BrianHarrisonAMD Oct 17, 2025
306e478
Merge branch 'users/bharriso/add-hipdnn' into users/bharriso/add-miop…
BrianHarrisonAMD Oct 18, 2025
ff99335
Merge remote-tracking branch 'origin/main' into users/bharriso/add-mi…
BrianHarrisonAMD Oct 18, 2025
9b6c613
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 20, 2025
47859da
Add smoke tests for miopen_plugin
BrianHarrisonAMD Oct 20, 2025
7cf5163
Fix comment spacing
BrianHarrisonAMD Oct 20, 2025
0a39f4b
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 20, 2025
d766187
Hardcode timeout and remove logging since it's handled generically by…
BrianHarrisonAMD Oct 20, 2025
2ebc4e7
Fix comments
BrianHarrisonAMD Oct 20, 2025
1e8aeac
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 22, 2025
b3be733
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 22, 2025
902995c
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 24, 2025
85a1e5a
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Oct 27, 2025
369019f
Add Windows support documentation for MIOpen plugin
BrianHarrisonAMD Oct 27, 2025
9cb1641
Merge remote-tracking branch 'origin/main' into users/bharriso/add-mi…
BrianHarrisonAMD Oct 30, 2025
9f4e56e
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Nov 3, 2025
7f07b41
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Nov 4, 2025
1c2638c
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Nov 6, 2025
a8f06df
Update testing time outs for hipDNN
BrianHarrisonAMD Nov 6, 2025
570de95
Merge branch 'main' into users/bharriso/add-miopen-plugin
BrianHarrisonAMD Nov 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,12 @@ if(NOT WIN32)
DESCRIPTION "Enables the hipDNN project"
REQUIRES COMPILER HIP_RUNTIME
)

therock_add_feature(MIOPEN_PLUGIN
GROUP ML_LIBS
DESCRIPTION "Enables the MIOpen plugin project"
REQUIRES COMPILER MIOPEN HIPDNN HIP_RUNTIME
)
endif()

# Finalize all feature flags.
Expand Down
33 changes: 17 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,22 +158,23 @@ Individual features can be controlled separately (typically in combination with
`-DTHEROCK_ENABLE_ALL=OFF` or `-DTHEROCK_RESET_FEATURES=ON` to force a
minimal build):

| Component flag | Description |
| ---------------------------------- | --------------------------------------------- |
| `-DTHEROCK_ENABLE_COMPILER=ON` | Enables the GPU+host compiler toolchain |
| `-DTHEROCK_ENABLE_HIPIFY=ON` | Enables the hipify tool |
| `-DTHEROCK_ENABLE_CORE_RUNTIME=ON` | Enables the core runtime components and tools |
| `-DTHEROCK_ENABLE_HIP_RUNTIME=ON` | Enables the HIP runtime components |
| `-DTHEROCK_ENABLE_OCL_RUNTIME=ON` | Enables the OpenCL runtime components |
| `-DTHEROCK_ENABLE_ROCPROFV3=ON` | Enables rocprofv3 |
| `-DTHEROCK_ENABLE_RCCL=ON` | Enables RCCL |
| `-DTHEROCK_ENABLE_PRIM=ON` | Enables the PRIM library |
| `-DTHEROCK_ENABLE_BLAS=ON` | Enables the BLAS libraries |
| `-DTHEROCK_ENABLE_RAND=ON` | Enables the RAND libraries |
| `-DTHEROCK_ENABLE_SOLVER=ON` | Enables the SOLVER libraries |
| `-DTHEROCK_ENABLE_SPARSE=ON` | Enables the SPARSE libraries |
| `-DTHEROCK_ENABLE_MIOPEN=ON` | Enables MIOpen |
| `-DTHEROCK_ENABLE_HIPDNN=ON` | Enables hipDNN |
| Component flag | Description |
| ----------------------------------- | --------------------------------------------- |
| `-DTHEROCK_ENABLE_COMPILER=ON` | Enables the GPU+host compiler toolchain |
| `-DTHEROCK_ENABLE_HIPIFY=ON` | Enables the hipify tool |
| `-DTHEROCK_ENABLE_CORE_RUNTIME=ON` | Enables the core runtime components and tools |
| `-DTHEROCK_ENABLE_HIP_RUNTIME=ON` | Enables the HIP runtime components |
| `-DTHEROCK_ENABLE_OCL_RUNTIME=ON` | Enables the OpenCL runtime components |
| `-DTHEROCK_ENABLE_ROCPROFV3=ON` | Enables rocprofv3 |
| `-DTHEROCK_ENABLE_RCCL=ON` | Enables RCCL |
| `-DTHEROCK_ENABLE_PRIM=ON` | Enables the PRIM library |
| `-DTHEROCK_ENABLE_BLAS=ON` | Enables the BLAS libraries |
| `-DTHEROCK_ENABLE_RAND=ON` | Enables the RAND libraries |
| `-DTHEROCK_ENABLE_SOLVER=ON` | Enables the SOLVER libraries |
| `-DTHEROCK_ENABLE_SPARSE=ON` | Enables the SPARSE libraries |
| `-DTHEROCK_ENABLE_MIOPEN=ON` | Enables MIOpen |
| `-DTHEROCK_ENABLE_MIOPEN_PLUGIN=ON` | Enables MIOpen_plugin |
Comment thread
BrianHarrisonAMD marked this conversation as resolved.
| `-DTHEROCK_ENABLE_HIPDNN=ON` | Enables hipDNN |

> [!TIP]
> Enabling any features will implicitly enable their *minimum* dependencies. Some
Expand Down
9 changes: 9 additions & 0 deletions build_tools/github_actions/fetch_test_configurations.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,15 @@ def _get_script_path(script_name: str) -> str:
"platform": ["linux"],
"total_shards": 1,
},
# MIOpen plugin tests
"miopen_plugin": {
"job_name": "miopen_plugin",
"fetch_artifact_args": "--blas --miopen --hipdnn --miopen-plugin --tests",
"timeout_minutes": 15,
"test_script": f"python {_get_script_path('test_miopen_plugin.py')}",
"platform": ["linux"],
"total_shards": 1,
},
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"--parallel",
"8",
"--timeout",
"10",
"60",
]
logging.info(f"++ Exec [{THEROCK_DIR}]$ {shlex.join(cmd)}")

Expand Down
Comment thread
BrianHarrisonAMD marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import logging
import os
import shlex
import subprocess
from pathlib import Path

THEROCK_BIN_DIR = os.getenv("THEROCK_BIN_DIR")
SCRIPT_DIR = Path(__file__).resolve().parent
THEROCK_DIR = SCRIPT_DIR.parent.parent.parent

logging.basicConfig(level=logging.INFO)

cmd = [
"ctest",
"--test-dir",
f"{THEROCK_BIN_DIR}/miopen_legacy_plugin",
"--output-on-failure",
"--parallel",
"8",
"--timeout",
"600",
]

# Determine test filter based on TEST_TYPE environment variable
environ_vars = os.environ.copy()
test_type = os.getenv("TEST_TYPE", "full")

if test_type == "smoke":
# Exclude tests that start with "Full" during smoke tests
environ_vars["GTEST_FILTER"] = "-Full*"

logging.info(f"++ Exec [{THEROCK_DIR}]$ {shlex.join(cmd)}")

subprocess.run(
cmd,
cwd=THEROCK_DIR,
check=True,
env=environ_vars,
)
24 changes: 21 additions & 3 deletions build_tools/install_rocm_from_artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(--artifact-group ARTIFACT_GROUP | --amdgpu_family AMDGPU_FAMILY)
[--output-dir OUTPUT_DIR]
(--run-id RUN_ID | --release RELEASE | --input-dir INPUT_DIR)
[--blas | --no-blas] [--fft | --no-fft] [--hipdnn | --no-hipdnn] [--miopen | --no-miopen] [--prim | --no-prim]
[--rand | --no-rand] [--rccl | --no-rccl] [--tests | --no-tests] [--base-only]
[--blas | --no-blas] [--fft | --no-fft] [--hipdnn | --no-hipdnn] [--miopen | --no-miopen] [--miopen-plugin | --no-miopen-plugin]
[--prim | --no-prim] [--rand | --no-rand] [--rccl | --no-rccl] [--tests | --no-tests] [--base-only]

Examples:
- Downloads and unpacks the gfx94X S3 artifacts from GitHub CI workflow run 14474448215
Expand Down Expand Up @@ -161,7 +161,16 @@ def retrieve_artifacts_by_run_id(args):
if args.base_only:
argv.extend(base_artifact_patterns)
elif any(
[args.blas, args.fft, args.hipdnn, args.miopen, args.prim, args.rand, args.rccl]
[
args.blas,
args.fft,
args.hipdnn,
args.miopen,
args.miopen_plugin,
args.prim,
args.rand,
args.rccl,
]
):
argv.extend(base_artifact_patterns)

Expand All @@ -175,6 +184,8 @@ def retrieve_artifacts_by_run_id(args):
extra_artifacts.append("hipdnn")
if args.miopen:
extra_artifacts.append("miopen")
if args.miopen_plugin:
extra_artifacts.append("miopen-plugin")
if args.prim:
extra_artifacts.append("prim")
if args.rand:
Expand Down Expand Up @@ -334,6 +345,13 @@ def main(argv):
action=argparse.BooleanOptionalAction,
)

artifacts_group.add_argument(
"--miopen-plugin",
default=False,
help="Include 'miopen-plugin' artifacts",
action=argparse.BooleanOptionalAction,
)

artifacts_group.add_argument(
"--prim",
default=False,
Expand Down
Loading
Loading