-
Notifications
You must be signed in to change notification settings - Fork 265
Enable TheRock to build rocALUTION #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsandham
wants to merge
5
commits into
ROCm:main
Choose a base branch
from
jsandham:add-rocalution-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2fc831c
Add rocalution to be built by TheRock
jsandham 43c29f1
Fix formatting issue in windows_support.md file
jsandham 6922bb6
Merge branch 'main' into add-rocalution-build
jsandham ab8a97d
Merge branch 'main' into add-rocalution-build
jsandham 235fb10
Merge branch 'main' into add-rocalution-build
jsandham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -407,6 +407,58 @@ if(THEROCK_ENABLE_ROCWMMA) | |
| ) | ||
| endif(THEROCK_ENABLE_ROCWMMA) | ||
|
|
||
| if(THEROCK_ENABLE_ROCALUTION) | ||
| ############################################################################## | ||
| # rocALUTION | ||
| ############################################################################## | ||
|
|
||
| therock_cmake_subproject_declare(rocALUTION | ||
| EXTERNAL_SOURCE_DIR "${THEROCK_ROCM_LIBRARIES_SOURCE_DIR}/projects/rocalution" | ||
| BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/rocALUTION" | ||
| BACKGROUND_BUILD | ||
| CMAKE_ARGS | ||
| -DHIP_PLATFORM=amd | ||
| -DROCM_PATH= | ||
| -DROCM_DIR= | ||
| -DSUPPORT_HIP=ON | ||
| -DSUPPORT_MPI=OFF | ||
| -DBUILD_CLIENTS_TESTS=${THEROCK_BUILD_TESTING} | ||
| -DBUILD_CLIENTS_BENCHMARKS=OFF | ||
| -DBUILD_CLIENTS_SAMPLES=OFF | ||
| -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON # Needed for Ninja build | ||
| CMAKE_INCLUDES | ||
| therock_explicit_finders.cmake | ||
| COMPILER_TOOLCHAIN | ||
| amd-hip | ||
| BUILD_DEPS | ||
| rocm-cmake | ||
| rocPRIM | ||
| therock-googletest | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, this also fails on Linux:
|
||
| RUNTIME_DEPS | ||
| hip-clr | ||
| rocBLAS | ||
| rocSPARSE | ||
| rocRAND | ||
| ) | ||
| therock_cmake_subproject_glob_c_sources(rocALUTION | ||
| SUBDIRS | ||
| . | ||
| ) | ||
| therock_cmake_subproject_provide_package(rocALUTION rocalution lib/cmake/rocalution) | ||
| therock_cmake_subproject_activate(rocALUTION) | ||
|
|
||
| therock_provide_artifact(rocalution | ||
| DESCRIPTOR artifact-rocalution.toml | ||
| COMPONENTS | ||
| dbg | ||
| dev | ||
| lib | ||
| test | ||
| SUBPROJECT_DEPS | ||
| rocALUTION | ||
| ) | ||
| endif(THEROCK_ENABLE_ROCALUTION) | ||
|
|
||
| if(THEROCK_ENABLE_LIBHIPCXX) | ||
| ############################################################################## | ||
| # libhipcxx | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # rocALUTION | ||
| [components.lib."math-libs/rocALUTION/stage"] | ||
| optional = true | ||
| [components.dbg."math-libs/rocALUTION/stage"] | ||
| optional = true | ||
| [components.dev."math-libs/rocALUTION/stage"] | ||
| include = [ | ||
| "include/rocalution/*", | ||
| "include/rocalution/**", | ||
| "lib/cmake/rocalution/*", | ||
| ] | ||
| [components.test."math-libs/rocALUTION/stage"] | ||
| optional = true | ||
| include = [ | ||
| # Clients tests (test_runner runs ctest from bin/rocalution/; needs CTestTestfile.cmake) | ||
| "bin/rocalution/**", | ||
| "bin/rocalution-test*", | ||
| "bin/*_rtest.xml", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are build errors on Windows:
This
therock-googletestbuild dep seems like it should be correct. OpenMP may be trickier, I'd need to check where that is expected to come from...We might want to start with rocALUTION only enabled on Linux to start bringup one platform at a time.