normalize single-token compiler vars in tbb build - #261
Merged
Conversation
when a Makevars sets e.g. 'CXX=$(CCACHE) g++' with CCACHE empty, the value expands to ' g++' with a leading space. splitCompilerVar() would tokenize this to a single token and return early without re-setting the variable, leaving the leading space in place and forwarding an invalid '-DCMAKE_CXX_COMPILER= g++' to cmake, breaking the bundled tbb build. re-set the compiler from the parsed tokens even when there are no trailing flags; scan() has already stripped surrounding whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a Makevars sets e.g. 'CXX=$(CCACHE) g++' with CCACHE empty, the value expands to ' g++' with a leading space. splitCompilerVar() would tokenize this to a single token and return early without re-setting the variable, leaving the leading space in place and forwarding an invalid '-DCMAKE_CXX_COMPILER= g++' to cmake, breaking the bundled tbb build.
re-set the compiler from the parsed tokens even when there are no trailing flags; scan() has already stripped surrounding whitespace.