Fix NameError from TYPE_CHECKING annotations evaluated at runtime#911
Open
Mia1Gohary wants to merge 1 commit into
Open
Fix NameError from TYPE_CHECKING annotations evaluated at runtime#911Mia1Gohary wants to merge 1 commit into
Mia1Gohary wants to merge 1 commit into
Conversation
Several modules imported types (e.g. Molecule, Atom, ARCSpecies) only under `if TYPE_CHECKING:`, but referenced them unquoted in real function/class signatures. Since those names never exist at runtime, importing arc.common (and transitively the rest of the package) raised NameError. Same issue affected a few self-referencing class annotations (e.g. Level, SSHClient) and one genuinely missing import in parser.py. Add `from __future__ import annotations` to defer annotation evaluation across all 53 affected files, and add the missing TYPE_CHECKING import for ARCSpecies in arc/parser/parser.py. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
@Mia1Gohary, Thanks for digging into this! The fix here, I think, should be in from typing import TYPE_CHECKING
if TYPE_CHECKING:
from arc.species.species import ARCSpeciesPleas reduce this PR to that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several modules imported types (e.g. Molecule, Atom, ARCSpecies) only under
if TYPE_CHECKING:, but referenced them unquoted in real function/class signatures. Since those names never exist at runtime, importing arc.common (and transitively the rest of the package) raised NameError. Same issue affected a few self-referencing class annotations (e.g. Level, SSHClient) and one genuinely missing import in parser.py.Add
from __future__ import annotationsto defer annotation evaluation across all 53 affected files, and add the missing TYPE_CHECKING import for ARCSpecies in arc/parser/parser.py.