Skip to content

4.x: Unit test lambdaification 21 of N#8163

Merged
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas21
Jun 22, 2026
Merged

4.x: Unit test lambdaification 21 of N#8163
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xUnitTestLambdas21

Conversation

@akarnokd

Copy link
Copy Markdown
Member

Will go over the unit tests in ASCII order of the classpath and classes.

IntelliJ: Inspect -> RedundantCast, Inspect -> Anonymous type can be replaced by lambda
Search regexp: new\s+\w+(?:\s*<(?:[\s\w<>(\[\])?,.?]|\s*<[\s\w<>(\[\])?,.?]*>)*>)?\s*\([^)]*\)\s*\{

/* NFI */ = Not Functional Interface so break the regexp pattern

If you complain instead of proposing a PR about "why not convert to method references" you'll be banned.

Related: #8080

@akarnokd akarnokd added this to the 4.0 milestone Jun 22, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.742 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/jmh/java/io/reactivex/rxjava4/core/XMapYPerf.java: 5.007
src/test/java/io/reactivex/rxjava4/internal/operators/mixed/SingleFlatMapObservableTest.java: 4.697
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleAmbTest.java: 4.643
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java: 4.750
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapCompletableTest.java: 4.860
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapMaybeTest.java: 4.797
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapTest.java: 4.764
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatPublisherTest.java: 4.922
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatTest.java: 4.713
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleContainstTest.java: 4.835
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java: 4.325
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java: 4.753
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDematerializeTest.java: 4.818
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java: 4.656
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java: 4.789
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterTerminateTest.java: 4.789
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoFinallyTest.java: 4.809
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTerminateTest.java: 4.808
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java: 4.663
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleErrorTest.java: 4.895

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.742 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/jmh/java/io/reactivex/rxjava4/core/XMapYPerf.java: 5.007
src/test/java/io/reactivex/rxjava4/internal/operators/mixed/SingleFlatMapObservableTest.java: 4.697
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleAmbTest.java: 4.643
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCacheTest.java: 4.750
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapCompletableTest.java: 4.860
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapMaybeTest.java: 4.797
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatMapTest.java: 4.764
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatPublisherTest.java: 4.922
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleConcatTest.java: 4.713
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleContainstTest.java: 4.835
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleCreateTest.java: 4.325
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDelayTest.java: 4.753
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDematerializeTest.java: 4.818
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDetachTest.java: 4.656
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterSuccessTest.java: 4.789
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoAfterTerminateTest.java: 4.789
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoFinallyTest.java: 4.809
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTerminateTest.java: 4.808
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleDoOnTest.java: 4.663
src/test/java/io/reactivex/rxjava4/internal/operators/single/SingleErrorTest.java: 4.895

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (4034581) to head (b199281).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8163      +/-   ##
============================================
+ Coverage     98.74%   98.77%   +0.02%     
- Complexity     6939     6943       +4     
============================================
  Files           773      773              
  Lines         48994    48994              
  Branches       6586     6586              
============================================
+ Hits          48381    48392      +11     
+ Misses          444      439       -5     
+ Partials        169      163       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit e8e1c4e into ReactiveX:4.x Jun 22, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xUnitTestLambdas21 branch June 22, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant