Fix implicit global variable in table-search.js - #6
Open
arijitroy003 wants to merge 1 commit into
Open
Conversation
Add const declaration to filter variable in searchTable() and filterTable() functions. Without let/const, the variable leaks into the global scope, which can cause unexpected behavior when both functions reference the same implicit global.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing variable declaration for
filterinsearchTable()andfilterTable(), which caused it to leak into the global scope.Changes
constdeclaration tofiltervariable insearchTable()(line 11)constdeclaration tofiltervariable infilterTable()(line 48)Verification
let/constvia grepfilterexist in the codebaseconstis appropriate here sincefilteris not reassigned within either function