refactor: infrastructure - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates infrastructure modules into a single core module, extracts api interfaces for tasks and console, fixes architecture violations in the data layer, and cleans up publishing.
Changes
Module Consolidation: core
Merged database, packets, events, and cache into a new core module. These four modules form the infrastructure layer (Redis DB, pub/sub communication, event dispatch, cluster cache) and had a strict dependency chain (events -> packets -> database, cache -> database + tasks). None were published as Maven artifacts.
API Interface Extraction
Task interfaces in apis:base-api (dev.redicloud.api.tasks):
Console interface in apis:base-api (dev.redicloud.api.console):
Architecture Fix: Decouple Data Layer from Console
The repositories and papermc-updater modules had a direct dependency on the console module (presentation layer).
Publishing Cleanup
Only modules containing interfaces/abstract classes are published:
Bugfixes
Documentation
KDoc docstrings added to all new and refactored files including all core module classes and new api interfaces.
Breaking Changes