Add configuration and harness smoke tests by vegaro · Pull Request #1014 · RevenueCat/purchases-unity

vegaro · 2026-07-24T16:04:36Z

Part of the #1006 split, stacked on #1009.

Adds baseline tests exercising the harness end to end: Configure forwarding through the wrapper spy, configuration builder defaults, presented-offering-context resolution, and baseline JSON model parsing.

Note

Low Risk
Test-only additions with no runtime SDK changes; low risk aside from documenting intentional configuration-builder default mismatches.

Overview
Adds EditMode NUnit tests under IntegrationTests/Assets/Tests/EditMode/ as part of the #1006 split (stacked on #1009). No production SDK code changes—only new test coverage and Unity .meta files.

Harness / configure: PurchasesCallTests wires Purchases to PurchasesWrapperSpy and asserts Configure forwards a fully populated PurchasesConfiguration to IPurchasesWrapper.Setup with all 14 arguments (including dangerous settings JSON).

Configuration builder: PurchasesConfigurationTests documents and locks in builder defaults vs inspector/docs (StoreKit 1, in-app messages off, verification disabled), custom builder values, and null DangerousSettings restoring defaults.

Models: PresentedOfferingContextTests covers JSON round-trip and minimal constructor serialization. JsonModelTests covers virtual currencies, subscription price micros above int32, store product category parsing, and unknown category fallback.

^{Reviewed by Cursor Bugbot for commit 14a1b01. Bugbot is set up for automated code reviews on this repo. Configure here.}

vegaro · 2026-07-24T16:04:57Z

Add configuration and harness smoke tests #1014 👈 (View in Graphite)
Add Unity Edit Mode test harness and CI job #1009 : 4 other dependent PRs (#1010 , #1011 , #1012 and 1 other)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

This one's pure harness/CI plumbing, no test content, so it's a small. Adds the `RevenueCat.Tests.EditMode` assembly, `PurchasesWrapperSpy`, and an internal `SetWrapper` hook (via `InternalsVisibleTo`) so tests can inject the spy into `Purchases`. Wires a `test-edit-mode` CircleCI job that imports the packaged SDK and runs the suite the same way CI already exercises the API tests. Stacked on top, each independent of the others: - #1014 configuration and harness smoke tests - #1010 wrapper pass-through tests - #1011 purchase forwarding & result parsing - #1012 single-request callback flows - #1013 tracking + model tests  --- > [!NOTE] > **Low Risk** > Changes are test/CI infrastructure plus a small internal injection hook on `Purchases`; no production purchase or auth behavior changes for shipped apps. > > **Overview** > Adds **Unity Edit Mode test plumbing** so later PRs can assert `Purchases` behavior against the **exported** `Purchases.unitypackage` / `PurchasesUI.unitypackage`. > > Introduces the Editor-only `RevenueCat.Tests.EditMode` assembly and a **`PurchasesWrapperSpy`** that records every `IPurchasesWrapper` call. **`Purchases.SetWrapper`** (internal, exposed via `InternalsVisibleTo` on the SDK assembly) lets tests inject the spy and keeps **`AdTracker`** wired to the same wrapper; platform `Start()` now goes through `SetWrapper` instead of assigning `_wrapper` directly. > > **CircleCI** broadens the pre-import “hide scripts” step to `Assets/Tests` (`.cs` and `.asmdef`), adds a **`test-edit-mode`** job (`unity/test` editmode after `import-package`), stores JUnit artifacts, and gates the release **hold** on that job. **IntegrationTests README** documents running Edit Mode tests locally via Test Runner. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a45f0a2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

Adds baseline tests exercising the harness end to end: Configure forwarding through the wrapper spy, configuration builder defaults, presented-offering-context resolution, and baseline JSON model parsing.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3af09b8. Configure here.}

cursor · 2026-07-27T12:22:22Z

+            Assert.That(virtualCurrencies.All["COIN"].Name, Is.EqualTo("Coins"));
+            Assert.That(virtualCurrencies.All["COIN"].ServerDescription, Is.EqualTo("Earned in game"));
+            Assert.That(virtualCurrencies.All["GEM"].Balance, Is.EqualTo(4));
+            Assert.That(virtualCurrencies.All["GEM"].ServerDescription, Is.Null);


Null currency description assertion fails

High Severity

VirtualCurrenciesParsesCurrenciesByCode expects ServerDescription to be C# null for a JSON null, but SimpleJSON's string conversion returns the literal "null" from JSONNull.Value. The assertion fails against current parsing behavior.

^{Reviewed by Cursor Bugbot for commit 3af09b8. Configure here.}

rickvdl

Nice first set of test cases 🫶 Codex and Cursor found a few mismatched with the assertions (that the test should hopefully catch), but overall looks good!

facumenzella

sweet

BuildUsesDocumentedDefaults asserted default(...) for StoreKitVersion, ShouldShowInAppMessagesAutomatically and EntitlementVerificationMode, which read as an endorsement of values that diverge from the inspector defaults on Purchases: the builder leaves these at their C# zero values, so the runtime-setup path gets StoreKit 1, in-app messages disabled and verification disabled. Assert the explicit current values and name each divergence, so the test guards today's behavior without claiming it is correct. Renamed to BuildUsesBuilderDefaults to match. Fixing the defaults is a runtime behavior change and is handled separately. Co-Authored-By: Claude <noreply@anthropic.com>

- Assert the serialized UseWorkflows flag alongside AutoSyncPurchases, and build DangerousSettings with differing values so the two keys can't be confused for each other. - Read the spy's only invocation instead of its last, matching what the Has.Count.EqualTo(1) guard already asserts. - Add a SUBSCRIPTION case for productCategory. The UNKNOWN fallback test alone would still pass if Enum.TryParse stopped matching anything. Co-Authored-By: Claude <noreply@anthropic.com>

@tonidero

**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * feat(paywalls): Add PaywallListener support to presented paywalls (SDK-4397) (#1001) via Toni Rico (@tonidero) ### 📦 Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.27.0 (#1026) via RevenueCat Git Bot (@RCGitBot) * [Android 10.15.1](https://github.com/RevenueCat/purchases-android/releases/tag/10.15.1) * [iOS 5.82.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.82.0) * [iOS 5.81.3](https://github.com/RevenueCat/purchases-ios/releases/tag/5.81.3) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.26.0 (#1021) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.25.0 (#1015) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 18.24.0 (#1007) via RevenueCat Git Bot (@RCGitBot) ### 🔄 Other Changes * Test wrapper pass-through calls (#1010) via Cesar de la Vega (@vegaro) * Add configuration and harness smoke tests (#1014) via Cesar de la Vega (@vegaro) * Add IOSPaywallPresentationStyle.FormSheet for iPad paywall presentation (#995) via Facundo Menzella (@facumenzella) * Bump fastlane-plugin-revenuecat_internal from `d392939` to `3421c88` (#1017) via dependabot[bot] (@dependabot[bot]) * Add Unity Edit Mode test harness and CI job (#1009) via Cesar de la Vega (@vegaro) * Use mise lockfile and install-mise-tools in CI (#997) via Álvaro Brey (@AlvaroBrey) * Bump json from 2.15.2.1 to 2.19.9 in /IntegrationTests (#1005) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `b52fca5` to `d392939` (#1004) via dependabot[bot] (@dependabot[bot])  --- > [!NOTE] > **Low Risk** > The diff only updates version strings and changelogs; no new SDK logic here. Underlying feature and dependency changes were merged separately and are documented in CHANGELOG. > > **Overview** > This PR is an **automatic release** that ships **9.6.0** by bumping version metadata everywhere it must stay aligned: `.version`, `RevenueCat/package.json`, `RevenueCatUI/package.json`, `VERSIONS.md`, and the reported plugin version in `PurchasesWrapper.java` and `PurchasesUnityHelper.m`. > > The **changelog** for 9.6.0 documents what landed since 9.5.3—not new code in this diff. Highlights for reviewers: **PaywallListener** on presented paywalls, **purchases-hybrid-common 18.27.0** (Android 10.15.1, iOS 5.82.0), **FormSheet** iPad paywall presentation style, plus CI/test harness work (Edit Mode tests, mise lockfile, wrapper pass-through tests). > > **Risk:** Low for this PR itself—it is versioning and release notes; runtime behavior changes come from the dependency bumps and features already merged on the release branch. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d8e79d2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

…1013) Part of the #1006 split. Rebased onto `main`; no longer stacked on anything. Adds `TrackingTests.cs` for custom paywall parameter resolution and ad-tracker forwarding/JSON serialization, and extends `JsonModelTests.cs` with full/minimal `CustomerInfo` and `SubscriptionOption` payloads, the epoch-vs-null date quirk, unrecognized-enum fallbacks, and the `WebPurchaseRedemption`/`WebPurchaseRedemptionResult` variants. ## The JsonModelTests overlap is resolved The earlier note here warned that this and #1014 both create `JsonModelTests.cs`. #1014 landed first, so I checked what `main` already has before rebasing: `main`'s version holds 4 tests (`VirtualCurrenciesParsesCurrenciesByCode`, `SubscriptionPriceSupportsValuesAboveInt32Range`, `StoreProductParsesKnownProductCategory`, `StoreProductFallsBackToUnknownProductCategory`), this branch's version is a strict superset containing those same 4 with byte-identical bodies plus 11 more. Nothing on `main` is unique, so the rebase keeps this version wholesale — no coverage lost, no duplication introduced. The file now has 15 tests. ## Second commit: fixture fidelity `MinimalCustomerInfoJson` omitted every field the mappers always send as an explicit null, plus `entitlements.verification`. Android's `convertToJson` maps Kotlin `null` to `JSONObject.NULL` and the iOS mappers use `NSNull()`, so those keys are on the wire, not absent. The web-redemption error fixture paired `"code":11` with `readableErrorCode: "UNKNOWN_ERROR"` — a value neither platform emits, and inconsistent with the code. Code 11 is `InvalidCredentialsError`, so it now carries the iOS values for that code plus the deprecated `readable_error_code` that ships alongside it. The synthetic `"UNRECOGNIZED"` and `"BOGUS"` values are unchanged and now carry comments: they stand in for enum members added natively before Unity knows the name, which is exactly what those fallback tests exist to pin down. Verified against purchases-hybrid-common 18.29.0, which is what `main` pins. The `redeemWebPurchase` result names and per-variant payload shapes (`customerInfo` on success, `error` on failure, `obfuscatedEmail` on expiry, bare `result` for the other two) already matched and were left alone. ## Verification - [x] Edit Mode tests: 49 passed, 0 failed. Packages rebuilt from this branch and re-imported so the run used this code. 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Test-only changes in IntegrationTests; no runtime SDK or purchase logic modified. > > **Overview** > Adds Edit Mode test coverage for JSON model parsing and analytics forwarding, with **no production code changes**. > > **JsonModelTests** moves inline JSON into a `JsonModelFixtures` folder and adds tests for full/minimal `CustomerInfo` and `SubscriptionOption` payloads, millis `0` vs null dates, unrecognized enum fallbacks, and all `WebPurchaseRedemptionResult` variants (including throw on unknown `result`). > > **TrackingTests** (new) uses `PurchasesWrapperSpy` to verify `TrackCustomPaywallImpression` parameter resolution (`CustomPaywallImpressionParams`, offering context from first package) and that ad tracker events (`TrackAdDisplayed`, revenue, load failures, etc.) forward to the wrapper with correct `ToJsonString` optional-field behavior. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 7c1a88a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).  --------- Co-authored-by: Claude <noreply@anthropic.com>

vegaro mentioned this pull request Jul 24, 2026

Add Unity Edit Mode test harness and CI job #1009

Merged

vegaro mentioned this pull request Jul 24, 2026

test: cover custom paywall tracking, ad tracker, and model parsing #1013

Merged

1 task

vegaro force-pushed the cesar/unity-edit-mode-test-infra branch from 3ded913 to 62ef6c4 Compare July 27, 2026 08:57

vegaro force-pushed the cesar/unity-configuration-smoke-tests branch 2 times, most recently from 2d7a57e to fddeb79 Compare July 27, 2026 09:00

vegaro force-pushed the cesar/unity-edit-mode-test-infra branch 2 times, most recently from 98db931 to c91fc0a Compare July 27, 2026 10:15

vegaro force-pushed the cesar/unity-configuration-smoke-tests branch from fddeb79 to 485bb0e Compare July 27, 2026 10:15

vegaro force-pushed the cesar/unity-edit-mode-test-infra branch from c91fc0a to a45f0a2 Compare July 27, 2026 10:20

vegaro force-pushed the cesar/unity-configuration-smoke-tests branch from 485bb0e to f4dd9a5 Compare July 27, 2026 10:20

Base automatically changed from cesar/unity-edit-mode-test-infra to main July 27, 2026 12:03

vegaro changed the title ~~test: add configuration and harness smoke tests~~ Add configuration and harness smoke tests Jul 27, 2026

vegaro added the pr:other Changes to our CI configuration files and scripts label Jul 27, 2026

test: add configuration and harness smoke tests

3af09b8

Adds baseline tests exercising the harness end to end: Configure forwarding through the wrapper spy, configuration builder defaults, presented-offering-context resolution, and baseline JSON model parsing.

vegaro force-pushed the cesar/unity-configuration-smoke-tests branch from f4dd9a5 to 3af09b8 Compare July 27, 2026 12:19

vegaro marked this pull request as ready for review July 27, 2026 12:20

vegaro requested a review from a team as a code owner July 27, 2026 12:20

vegaro requested review from facumenzella and rickvdl July 27, 2026 12:20

cursor Bot reviewed Jul 27, 2026

View reviewed changes

rickvdl approved these changes Jul 27, 2026

View reviewed changes

Comment thread IntegrationTests/Assets/Tests/EditMode/PurchasesConfigurationTests.cs Outdated

Comment thread IntegrationTests/Assets/Tests/EditMode/PurchasesConfigurationTests.cs Outdated

facumenzella reviewed Jul 28, 2026

View reviewed changes

Comment thread IntegrationTests/Assets/Tests/EditMode/PurchasesCallTests.cs

facumenzella reviewed Jul 28, 2026

View reviewed changes

Comment thread IntegrationTests/Assets/Tests/EditMode/PurchasesCallTests.cs Outdated

facumenzella reviewed Jul 28, 2026

View reviewed changes

Comment thread IntegrationTests/Assets/Tests/EditMode/JsonModelTests.cs

facumenzella approved these changes Jul 28, 2026

View reviewed changes

vegaro mentioned this pull request Jul 28, 2026

fix: align PurchasesConfiguration.Builder defaults with the inspector #1018

Draft

vegaro enabled auto-merge (squash) July 28, 2026 12:20

Merge branch 'main' into cesar/unity-configuration-smoke-tests

14a1b01

vegaro merged commit 37359f1 into main Jul 28, 2026
14 checks passed

vegaro deleted the cesar/unity-configuration-smoke-tests branch July 28, 2026 12:32

This was referenced Jul 29, 2026

[AUTOMATIC] Release/9.6.0 #1025

Closed

[AUTOMATIC] Release/9.6.0 #1027

Merged

Navigation Menu

Uh oh!

Add configuration and harness smoke tests - #1014

Add configuration and harness smoke tests#1014
vegaro merged 4 commits into
mainfrom
cesar/unity-configuration-smoke-tests

vegaro commented Jul 24, 2026 •

edited by cursor Bot

Loading

Uh oh!

vegaro commented Jul 24, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Jul 27, 2026

Uh oh!

Uh oh!

rickvdl left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facumenzella left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vegaro commented Jul 24, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vegaro commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 27, 2026

Choose a reason for hiding this comment

Null currency description assertion fails

Uh oh!

Uh oh!

rickvdl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facumenzella left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vegaro commented Jul 24, 2026 •

edited by cursor Bot

Loading

vegaro commented Jul 24, 2026 •

edited

Loading