Skip to content

chore: clear the PR backlog and fix 18 open issues - #184

Merged
Rinava merged 20 commits into
mainfrom
claude/vibrant-fermi-rf8s2j
Nov 11, 2026
Merged

Rinava merged 20 commits into
mainfrom
claude/vibrant-fermi-rf8s2j

Conversation

@Rinava

@Rinava Rinava commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Description

One branch that lands the open PRs that were ready, replaces the pile of Dependabot bumps with a single update, and works through the open issues that could be fixed without a product decision. Each issue has its own commit, so it can be reviewed (or reverted) piece by piece.

Open PRs folded in

Issues fixed

Issue What changed
#46 Sitemap lastModified is a fixed date, not new Date()
#68 Deleted the unused src/lib/export-markdown.tsx
#69 MarkdownEditor reduced to the one mode that is used
#71 skillQualityHints is wired into the skill inspector as warning rows
#75 Toolbar formatting engine moved to src/lib/markdown/format.ts with 30 tests
#76 Named constants, lookup maps over nested ternaries, color tokens, simpler useAnalytics
#80 overrides pins documented in CONTRIBUTING, stale Dependabot ignore removed
#84 /api/skill/improve: rate limit, and a missing Origin is rejected
#85 CSP script-src drops the 'unsafe-inline' / https: legacy fallback
#121 Google Analytics ID comes from NEXT_PUBLIC_GA_ID
#122 /api/mcp: per-IP rate limit (429 + Retry-After) and a 2 MB body cap (413)
#123 Export was already sanitized by remark-html; now pinned by tests and documented
#124 Vitest runs *.test.tsx in jsdom with Testing Library
#125 Tests for marketplace discovery, import caps, contributors, storage and debounce hooks
#126 CHANGELOG [Unreleased] backfilled
#129 npm run typecheck, CI step, engines aligned on Node 22

Things worth a look before merging

Not done here

Related issue

Closes #41, closes #43, closes #46, closes #68, closes #69, closes #71, closes #75, closes #76, closes #80, closes #84, closes #85, closes #121, closes #122, closes #123, closes #124, closes #125, closes #126, closes #129.

Closes #19 and closes #37 as obsolete (see above).

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing behavior)
  • 📖 Documentation
  • 🧹 Refactor / chore (no user-facing change)

Breaking for deployers only: Node 22 minimum, GA needs NEXT_PUBLIC_GA_ID, and the SSE MCP transport is gone (from #158).

Screenshots / recording

The only visible change is the extra warning rows in the skill inspector's validation list ("Description style", "Body length", "Instruction structure"), which reuse the existing row styling.

Checklist

  • My branch is up to date with main
  • npm run lint passes (0 errors, the one existing set-state-in-effect warning in outline-rail.tsx)
  • npm test passes (158 tests, up from 87)
  • npm run build succeeds
  • I tested my change in the browser (production build: toolbar buttons and shortcuts, caret fix, lazy images, skill inspector, no CSP violations; MCP initialize and tools/call, 413, 429 and the Origin guard with curl)
  • My commits follow Conventional Commits
  • I updated docs where relevant

Generated by Claude Code

shrutig-blip and others added 20 commits August 13, 2026 20:08
mcp-handler 2.x drops the 3rd config arg (basePath/maxDuration) and the SSE transport, and swaps its required peer dep to @modelcontextprotocol/server v2. Move the handler to a static /api/mcp route (the [transport] dynamic segment only existed for the now-removed SSE transport), collapse createMcpHandler to its one-arg form, and re-express maxDuration as a Next.js route-segment export. Drop the orphaned @modelcontextprotocol/sdk v1 (imported nowhere after this). Verified: next build, 87/87 tests, plus a live initialize + tools/list against the built /api/mcp endpoint.
Brings Next.js to 16.4.6 and refreshes every dependency within its
declared range, covering the open Dependabot bumps (vite, hono, vitest,
dompurify, sharp, js-yaml, qs, fast-uri, brace-expansion and friends)
in one pass. npm audit drops from 25 findings (2 critical, 7 high) to
12 low/moderate ones that have no non-breaking fix yet.
new Date() moved <lastmod> on every deploy, which told crawlers the
pages had changed when they hadn't. The dates are now constants that
get bumped by hand when the content really changes.

Closes #46
Nothing imported src/lib/export-markdown.tsx. The app exports through
renderMarkdownToHtml in src/lib/markdown/to-html.ts.

Closes #68
The ID was hardcoded, so every fork and self-hosted copy reported its
visitors to the upstream property. GA now loads only when a deployment
sets NEXT_PUBLIC_GA_ID, and .env.example documents it as optional.

Closes #121
…t-src

CSP3 browsers already ignore both next to strict-dynamic, but CSP2-only
browsers honored them, which switched off XSS protection there. The
trade-off (no third-party analytics on those legacy browsers) is
documented next to the policy.

Closes #85
npm run typecheck runs tsc --noEmit so type errors show up in seconds
instead of at the end of a full build, and CI runs it before the build.
engines now says >=22, which matches .nvmrc and what CI tests.

Closes #129
Also drops the Dependabot ignore for @modelcontextprotocol/sdk, which
is no longer a dependency after the mcp-handler v2 migration. The
malformed AI-SDK entry in .env.example was already gone.

Closes #80
The export body was already sanitized (remark-html sanitizes by
default), but a stale comment called it unsanitized and nothing tested
it. Adds regression tests for script tags, event handlers and
javascript: URLs, corrects the comment, and tells MCP callers what
markdown_to_html returns.

Closes #123
Adds one small limiter (src/lib/rate-limit.ts) that both public routes
share. It counts per client IP in Upstash Redis when
UPSTASH_REDIS_REST_URL/TOKEN are set, and falls back to an in-memory
window per instance when they aren't.

/api/mcp: 60 requests a minute per IP, 429 with Retry-After beyond
that, and a 2 MB request body cap checked against the bytes that really
arrive (413).

/api/skill/improve: 10 requests a minute per IP, and a missing Origin
header is now rejected like a mismatched one, so curl without Origin no
longer skips the guard.

Closes #122
Closes #84
Vitest now runs two projects picked by extension: *.test.ts in Node and
*.test.tsx in jsdom with Testing Library. Before this a .test.tsx file
was silently skipped by the include glob. Seeds it with a fake-timer
test for useDebouncedValue.

Closes #124
Adds tests for the GitHub tree filtering in discoverSkills (including
lookalike path prefixes), the 30 file and 1 MB caps in importSkillDir,
sizedAvatar and bot filtering in fetchContributors, and the JSON
fallback paths of useLocalStorage.

Closes #125
…itor

The only caller always passed bare with showToolbar={false}, so the
ring-styled wrapper, its embedded toolbar, the focus state and the
analytics hook never ran. The component is now just the editor the
workspace uses.

Closes #69
…t.ts

smartInsert, smartHeading, insertLine, removeFormatting and
replaceFormatting are now pure functions that take the document text
and selection and return an edit, with 30 unit tests. The toolbar keeps
the buttons, shortcuts and analytics and drops from 624 to 351 lines.

The tests surfaced one bug, fixed here: toggling a format off left the
caret a full word too far right, and at the end of a short document the
position landed outside the document.

Closes #75
… show quality hints

Readability pass over the workspace UI, no behavior change:
- split-pane bounds, resize step, preview debounce, reading speed and
  the print delay are named constants
- the skill inspector's stacked ternaries are lookup maps keyed by status
- the two raw hex colors are ms-script and ms-tip-muted tokens
- useAnalytics returns stable module-level functions instead of
  wrapping each one in useCallback

Also wires skillQualityHints into the inspector's validation list. It
was only ever called from its test. "Trigger clarity" now uses the same
tested rule, and the other hints (generic description, long body, no
instruction-shaped headings) appear as warning rows when they apply.
They never block export.

Closes #76
Closes #71
Adds the merged features that never made it into the changelog (code
block copy button, custom export file name, skip link, README shortcuts
and screenshots, among others) and the changes from this branch.

Closes #126
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mark-sight Ready Ready Preview Nov 10, 2026 11:49pm UTC

Request Review

Rinava commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

CI note: "Lint and build" and both CodeQL "Analyze" jobs are red, but not because of this diff.

  • Every Actions job ends 2 to 3 seconds after it is created, with no runner assigned (runner_id: 0), no steps and no logs. Nothing gets as far as checkout.
  • It hits two unrelated workflows (CI and CodeQL) at once, and one re-run of the CI job failed the same way.
  • On the same commit, npm ci, npm run lint, npm run format:check, npm run typecheck, npm test (158 tests) and npm run build all pass locally on Node 22.

That pattern usually means the jobs are being refused before they start: an Actions spending limit, used-up minutes, a billing problem, or a GitHub Actions incident. There is nothing to fix in the branch for it, and I can't see the account's billing or usage from here. The last green Actions run on this repo was October 22.

Once Actions is accepting jobs again, re-running the failed jobs should give a real result.


Generated by Claude Code

@Rinava
Rinava marked this pull request as ready for review November 11, 2026 00:12
@Rinava
Rinava merged commit 11e571a into main Nov 11, 2026
2 of 6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 992254fc Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment