Skip to content

[Fix] App image builds fail during npm publication races #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Fix] App image builds fail during npm publication races #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .docker/app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,12 @@ RUN cd /roomote && pnpm dlx esbuild@0.25.5 packages/db/src/run-migrations.ts \
--banner:js="import{createRequire as __createRequire}from 'module';const require=__createRequire(import.meta.url);" && \
cp -R packages/db/drizzle /migrate/drizzle

# Runtime-only dependency tree for the externals tsup does not bundle.
RUN mkdir -p /runtime-deps && cd /runtime-deps && npm init -y >/dev/null && \
npm install --omit=dev --no-audit --no-fund \
"snowflake-sdk@$(cd /roomote/apps/api && node -p "require('snowflake-sdk/package.json').version")"
# Runtime-only dependency tree for the externals tsup does not bundle. Keep its
# transitive versions locked so image builds do not resolve a new tree from npm.
COPY .docker/app/runtime-deps/package.json .docker/app/runtime-deps/package-lock.json /runtime-deps/
RUN test "$(node -p "require('snowflake-sdk/package.json').version")" = \
"$(node -p "require('/runtime-deps/package.json').dependencies['snowflake-sdk']")" && \
cd /runtime-deps && npm ci --omit=dev --no-audit --no-fund

# ---------------------------------------------------------------------------
# controller: bundled dist plus the packaged worker release archives that the
Expand Down
Loading
Loading