fix(wasapi): racy timestamp callback padding#1246
Merged
Merged
Conversation
This was referenced Jun 9, 2026
roderickvd
force-pushed
the
fix/wasapi-racy-callback-padding
branch
from
0cf8034 to
582d5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-v0.18 the WASAPI playback timestamps were not monotonic because the padding calculation was backward. v0.18 made that go away for the most part here, but still keeps a tiny window between two syscalls that could make it go awry.
This PR does an atomic read on the callback timestamp and playback position instead of those two syscalls.
Fixes BillyDM/Firewheel#43