feat: add interactive startup wizard#868
Open
darwvin-dev wants to merge 3 commits into
Open
Conversation
Member
|
I like the idea tbh. I remember myself trying it for the first time. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Author
|
Thanks for the positive feedback. I also followed up on the GitHub Advanced Security note by documenting the larger startup wizard flow in the latest commit ( Current status on the latest head:
|
There was a problem hiding this comment.
Pull request overview
Adds an interactive startup wizard that runs when SIPp is launched with no arguments on an interactive terminal, guiding users to build common -sn / -sf command lines while preserving the existing help behavior for non-interactive no-argument runs.
Changes:
- Introduces a startup wizard (scenario/transport/target/load prompts) and translates answers into normal argv-style options.
- Updates
main()to invoke the wizard only for interactive no-argument launches. - Extends help text to mention the no-argument invocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+143
to
+145
| {"branchs", "Embedded server branching scenario.", false, false}, | ||
| {"uac_pcap", "Embedded UAC scenario with PCAP media playback.", true, false}, | ||
| {"custom", "Custom XML scenario file.", false, true}, |
Comment on lines
+426
to
+428
| if (!remote_host_value.empty()) { | ||
| args.push_back(remote_host_value); | ||
| } |
| if (i != 0) { | ||
| std::cout << " "; | ||
| } | ||
| std::cout << args[i]; |
| "\n" | ||
| "Example:\n" | ||
| "\n" | ||
| " Launch the interactive startup wizard:\n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Start an interactive startup wizard when SIPp is launched without arguments on an interactive terminal. The wizard helps users build common -sn and -sf command lines and preserves the existing help behavior for non-interactive no-argument runs.
Reasoning:
Launching SIPp without arguments is a common first-touch path, especially for users who are exploring the built-in scenarios or validating a new build. Today that path drops straight to the generic help output, which is complete but still leaves the user to translate their intent into a working command line.
This wizard is meant to reduce that startup friction without changing batch or scripted behavior. It only runs when both stdin and stdout are interactive, it keeps the current help path for non-interactive usage, and it only offers scenario and transport choices that are supported by the current build.
What is included:
What is not included: