tests: adding gpo test case for traversal bug - #8952
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new system test test_gpo__rejects_path_traversal_in_gpo_file_sys_path to verify that SSSD correctly rejects Group Policy Objects (GPOs) containing path traversal components in their gPCFileSysPath attribute, ensuring access is denied in enforcing mode. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
Looks good, just make sure not to merge the temporary commit.
ce0221f to
143a088
Compare
|
Failures are not related, https://github.com/SSSD/sssd/actions/runs/29554224723/job/87802985201?pr=8952 Removing temporary commit. |
143a088 to
c05bd69
Compare
|
The pull request was accepted by @jakub-vavra-cz with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
c05bd69 to
1cfb67d
Compare
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
Static analysis screams now.
1cfb67d to
1c748a1
Compare
Depends on SSSD/sssd-test-framework#260