DONOTMERGE: Temporary commit for testing

[spoore1]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces a new system test for Active Directory smartcard authentication (test_smartcard_ad.py) and updates the test framework requirements. Feedback on the changes includes reverting the dependency on a personal fork in requirements.txt back to the official upstream repository, removing unused imports and commented-out code blocks in the new test file, and optimizing the user lookup polling loop to avoid an unnecessary initial sleep delay.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The requirements file has been modified to point to a personal fork and branch (spoore1/sssd-test-framework@adcs_smartcard_setup_v2) instead of the official upstream repository. This must be reverted to the official SSSD repository before merging to ensure stability and avoid supply chain risks.

git+https://github.com/SSSD/sssd-test-framework

[gemini-code-assist]

The imports GenericADProvider and KnownTopologyGroup are not used anywhere in this test file. Removing unused imports keeps the codebase clean and adheres to PEP 8 guidelines.

Suggested change

	from sssd_test_framework.roles.generic import GenericADProvider
	from sssd_test_framework.topology import KnownTopology, KnownTopologyGroup
	from sssd_test_framework.topology import KnownTopology

[gemini-code-assist]

This block of commented-out code should be removed to keep the test suite clean and maintainable.

Suggested change

	# client.host.conn.run("rm -f /etc/krb5.conf /etc/krb5.keytab", raise_on_error=False)
	# client.host.conn.run(
	# f"realm join {ad.domain}",
	# input=ad.host.adminpw,
	# raise_on_error=False,
	# )

[gemini-code-assist]

This block of commented-out code should be removed to keep the test suite clean and maintainable.

Suggested change

	#
	# client.host.conn.run(
	# r"sed -i 's/\[default=2 ignore=ignore success=ok\]\s*pam_localuser.so/"
	# r"[default=ignore ignore=ignore success=ok] pam_localuser.so/' "
	# r"/etc/pam.d/system-auth",
	# )
	#
	# client.sssd.config_load()

[gemini-code-assist]

The loop always sleeps for 3 seconds on the very first iteration before checking if the user is available. Checking the passwd database first before sleeping avoids an unnecessary 3-second delay in the happy path, improving test suite efficiency.

Suggested change

	for _attempt in range(10):
	time.sleep(3)
	result = client.tools.getent.passwd(fqdn_user)
	if result is not None:
	break
	if _attempt == 2:
	client.host.conn.run("sss_cache -E", raise_on_error=False)
	for _attempt in range(10):
	result = client.tools.getent.passwd(fqdn_user)
	if result is not None:
	break
	if _attempt == 2:
	client.host.conn.run("sss_cache -E", raise_on_error=False)
	time.sleep(3)