KCM: fix TGT renewal use-after-free and stabilize test - #9005
Open
danlavu wants to merge 3 commits into
Open
Conversation
auth_data->ccname pointed at cc->name on a short-lived tmp_ctx that is freed before the tevent immediate renewal callback runs. Copy the name onto auth_data so krb5_child renews the correct KCM ccache. Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5
Avoid leaking the partially initialized auth_data when strdup or tevent_create_immediate fails in kcm_creds_check_times(). Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5
Use a 10s lifetime and 30s renewable life so renew_till stays past endtime, and poll for half-life plus slack after the UAF fix. Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5
danlavu
force-pushed
the
kcm-fix-tgt-renewal-uaf
branch
from
July 24, 2026 18:19
6ff2281 to
4492f44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth_data->ccnamepointed at a short-livedtmp_ctxccache name freed before the tevent renewal callback (caused flaky renewals against bogus names likeKCM:p).auth_dataon strdup /tevent_create_immediatefailure paths.Replaces the exploratory work in #8857.
Co-authored-by: Cursor cursoragent@cursor.com
Model used: Cursor Sonnet 5