add mobile breadcrumb#4724
Open
micsblank wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
Contributor
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from 294c971 |
Contributor
|
Deployed changes to https://app-sswwebsite-9eb3-pr-4724.azurewebsites.net |
Contributor
Contributor
|
Deployed changes to https://app-sswwebsite-9eb3-pr-4724.azurewebsites.net |
Contributor
🚀 Lighthouse score comparison for PR slot and production
|
Contributor
|
Deployed changes to https://app-sswwebsite-9eb3-pr-4724.azurewebsites.net |
Contributor
🚀 Lighthouse score comparison for PR slot and production
|
joshbermanssw
added
the
no-issue
joshbermanssw
requested changes
Jun 4, 2026
| className="unstyled inline-flex items-center gap-1 text-xs text-gray-700 no-underline hover:text-sswRed" | ||
| aria-label={`Back to ${mobileParent.label}`} | ||
| > | ||
| <svg |
Member
There was a problem hiding this comment.
Instead of can we use a component from the component library (whatever the chevron is from the other breadcrubm list)
| className="unstyled inline-flex items-center gap-1 text-sm no-underline transition-colors hover:text-white" | ||
| aria-label={`Back to ${mobileParent.label}`} | ||
| > | ||
| <svg |
Member
There was a problem hiding this comment.
same here - no need to use sg
Member
Author
There was a problem hiding this comment.
@copilot same here, no need to use SVG, please use an existing component
Comment on lines
+108
to
+117
| const mobileParent = | ||
| segments.length >= 2 | ||
| ? { | ||
| label: | ||
| global.breadcrumbReplacements.find( | ||
| (value) => value.from === segments[segments.length - 2] | ||
| )?.to || segments[segments.length - 2], | ||
| href: `/${segments[segments.length - 2]}`, | ||
| } | ||
| : { label: global.breadcrumbHomeRoute, href: "/" }; |
Member
There was a problem hiding this comment.
This .find(...)?.to || rawSlug lookup is a bit convoluted, and it's a hand-written second copy of the same slug→label logic that lives in app/components/breadcrumb.tsx (getDisplayName). Consider a small Map instead, e.g. build it once:
const replacementMap = new Map(
global.breadcrumbReplacements.map((r) => [r.from, r.to])
);
const parent = segments[segments.length - 2];
const label = replacementMap.get(parent) ?? parent;Cleaner to read, and better still if the whole mobile back-link were extracted into one shared component so the two breadcrumb files can't drift (the href already differs between them — full path here vs. single segment).
isaaclombardssw
approved these changes
Jun 4, 2026
Comment on lines
+146
to
+158
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="12" | ||
| height="12" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| aria-hidden="true" | ||
| > | ||
| <path d="M15 18l-6-6 6-6" /> |
Contributor
|
Deployed changes to https://app-sswwebsite-9eb3-pr-4724.azurewebsites.net |
Contributor
🚀 Lighthouse score comparison for PR slot and production
|
Contributor
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
Contributor
|
🧹 Your staging deployment was removed during weekly cleanup because this PR has been inactive for over 7 days. Push a new commit (or re-run the PR - build and deploy to slot workflow) to spin up a fresh staging environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making breadcrumbs mobile reactive and rule compliant