Repository navigation
Fix duplicate affiliation error - #150
Draft
EricvanSchaik wants to merge 3 commits into
Draft
EricvanSchaik wants to merge 3 commits into
EricvanSchaik wants to merge 3 commits into
Conversation
EricvanSchaik
force-pushed
the
fix/duplicate-affiliation-error
branch
from
July 21, 2026 15:17
4fac241 to
974ddba
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on this PR from @mrvanes https://github.com/SURFscz/plsc/pull/149/changes.
Running the tests results in formatting changes, which is very annoying, but the relevant change in the test data file is op line 739/712:
"scoped_affiliation": null,->"scoped_affiliation": "member@surfstar-idp.lab.surf.nl, employee@surfstar-idp.lab.surf.nl, employee@surfstar-idp.lab.surf.nl",Met deze change is te verifiëren dat zonder de change van @mrvanes in
sldap.pyde tests falen, en met die change de tests slagen.