Add microphone cutoff option#15
Open
sandstorm244 wants to merge 2 commits into
Open
Conversation
Member
|
Lgtm for the most part, only thing I noticed is in that screenshot there's a huge gap between the checkbox and the slider? Could you adjust that styling so it's more consistent (although I know some of the other settings aren't consistent, but i'd like to start trying to get them more uniform) |
Author
Author
|
Not super relevant to this specific PR but im sure these patches might be interesting, fixes a couple of issues. Aswell as a custom client with venmic implemented (mega ai slop warning, but i've tested it pretty rigorously and it seems stable enough) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Content
Adds a user-configurable microphone cutoff volume (noise gate): mic input quieter than a chosen dBFS threshold is muted before being published.
AudioWorklet(level-based, with hysteresis, ~300ms hold and open/close gain smoothing) — works with RNNoise enabled or disabledMotivation and context
Because noise supression just isnt enough, a cut-off helps quite alot.
Similar PR upstream got closed for some reason perhaps we can have this nice feature here?
Screenshots / GIFs
Tests
lint:types,lint:oxlint,lint:knip,format:check,i18n:check,build:full,build:embeddedall passFor transparency sake, i have used AI in this PR.
Feel free to adjust or close if there is a better implementation.