Skip to content

[tools/onnx-subgraph] add config.json for onnx model splitting #14852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanshpark merged 2 commits into from
Mar 18, 2025
Merged

[tools/onnx-subgraph] add config.json for onnx model splitting #14852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed803e6
[tools/onnx-subgraph] add config.json for onnx model splitting
chenyx113 Mar 13, 2025
5751d0e
add config.json as examples
chenyx113 Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/onnx_subgraph/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ set(ONNX_SUBGRAPH_FILES
extract_onnx.py
subgraphs_ios.txt
single_vs_multiple_onnx.py
config.json
)
foreach(ONNX_SUBGRAPH IN ITEMS ${ONNX_SUBGRAPH_FILES})
set(ONNX_SUBGRAPH_FILE ${ONNX_SUBGRAPH})
Expand Down
13 changes: 13 additions & 0 deletions tools/onnx_subgraph/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"NPU_supported_ops": ["Conv", "Reshape", "Transpose", "Add", "ReduceMean", "Sub", "Div", "Mul", "Sigmoid","MatMul"],
"CPU_supported_ops": ["Sub", "Pow", "ReduceMean", "Add", "Sqrt", "Div","Transpose", "Gather", "MatMul", "Mul", "Softmax", "Erf", "Gemm", "Conv", "Reshape",
"Sin", "Where", "ConstantOfShape", "Cast", "Sigmoid", "Cos", "Expand", "Slice", "Unsqueeze"],

@seanshpark seanshpark Mar 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if you could split lines so that text comes inside 100 cols.

"performance_data": [
{"name":"Conv","CPU_time": 0.1, "NPU_time": 0.05},
{"name":"Mul", "CPU_time": 0.15, "NPU_time": 0.07}

@seanshpark seanshpark Mar 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, if the performance data is changed by targets, we should update these values.
update to these won't be good with source code management.
So, I suggest not to put these in here but to explain in the README file to add in performance_data item.
And/Or you can provide something like config.sample.json file with explanation in README so that users can follow by an example.

@chenyx113 chenyx113 Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree with you, I add it to examples path, and will add description for this config in readme later, thank you

],
"hardware_limits": {

@seanshpark seanshpark Mar 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"max_subgraph_size": 60024.0,
"max_subgraphs": 5
}
}