[exo] Fix for gcc-13 overloaded-virtual#15239
Merged
Merged
Conversation
Contributor
Author
seanshpark
force-pushed
the
exo_override_gcc13
branch
from
fadb674 to
d7f19f4
Compare
This will fix for gcc-13 overloaded-virtual option on U24.04 build. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
seanshpark
force-pushed
the
exo_override_gcc13
branch
from
d7f19f4 to
583b286
Compare
shs-park
approved these changes
Apr 28, 2025
shs-park
left a comment
shs-park
left a comment
Contributor
There was a problem hiding this comment.
I left a question,
but the code LGTM
=)
Comment on lines
+132
to
+144
| // NOTE adding visit() to make compiler happy with "-Werror=overloaded-virtual=" | ||
| void visit(loco::Node *) final { assert(false); } | ||
| void visit(loco::MatMul *) final { assert(false); } | ||
| void visit(loco::MatrixDecode *) final { assert(false); } | ||
| void visit(loco::MatrixEncode *) final { assert(false); } | ||
| void visit(loco::TensorTranspose *) final { assert(false); } | ||
| void visit(loco::Forward *) final { assert(false); } | ||
| void visit(loco::FilterDecode *) final { assert(false); } | ||
| void visit(loco::DepthwiseFilterDecode *) final { assert(false); } | ||
| void visit(loco::BiasDecode *) final { assert(false); } | ||
| void visit(locoex::TFLNode *) final { assert(false); } | ||
| void visit(locoex::CircleNode *) final { assert(false); } | ||
|
|
Contributor
There was a problem hiding this comment.
Question,
Does this mean these operations are currently not supported for export?
Contributor
Author
There was a problem hiding this comment.
I think these are not for circle or tflite dialect so not need to be exported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix for gcc-13 overloaded-virtual option on U24.04 build.