[moco] Do not use reference for dangling variable#15243
Merged
Conversation
This will fix not to use reference for dangling variable inside callee. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
Contributor
Author
inside callee, local variable is used so using reference would be dangling const auto &attr = node.attr().at(attr_name);
assert(attr.value_case() == tensorflow::AttrValue::kShape);
return attr.shape(); |
shs-park
approved these changes
Apr 28, 2025
shs-park
left a comment
shs-park
left a comment
Contributor
There was a problem hiding this comment.
I left a question, PTAL
=)
| if (!plier::tf::has_attrs(node, {"dtype", "value"})) | ||
| return false; | ||
|
|
||
| const auto &input_tensor = plier::tf::get_tensor_attr(node, "value"); |
Contributor
There was a problem hiding this comment.
Question,
Did this old code trigger a dangling variable error in Ubuntu 24.04?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix not to use reference for dangling variable inside callee.