[common-artifacts] Split python package list#15319
Merged
Merged
Conversation
This will split python package list by python version 3.8 and 3.10. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
Contributor
Author
shs-park
reviewed
May 8, 2025
shs-park
left a comment
shs-park
left a comment
Contributor
There was a problem hiding this comment.
I left a question,
PTAL
=)
Comment on lines
+77
to
+102
| if (PYTHON_VERSION_MINOR EQUAL 8) | ||
| # python3.8; Ubuntu 18.04, 20.04 | ||
| if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "tensorflow==2.12.1") | ||
| else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "tensorflow-cpu==2.12.1") | ||
| endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "flatbuffers==23.5.26") | ||
| list(APPEND PY_PKG_LIST "protobuf==4.23.3") | ||
| list(APPEND PY_PKG_LIST "pydot==1.4.2") | ||
| list(APPEND PY_PKG_LIST "pytest==7.4.3") | ||
| list(APPEND PY_PKG_LIST "h5py==3.11.0") | ||
| list(APPEND PY_PKG_LIST "cffi==1.16.0") | ||
| elseif (PYTHON_VERSION_MINOR EQUAL 10) | ||
| # python 3.10; Ubuntu 22.04 | ||
| if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "tensorflow==2.12.1") | ||
| else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "tensorflow-cpu==2.12.1") | ||
| endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | ||
| list(APPEND PY_PKG_LIST "flatbuffers==23.5.26") | ||
| list(APPEND PY_PKG_LIST "protobuf==4.23.3") | ||
| list(APPEND PY_PKG_LIST "pydot==1.4.2") | ||
| list(APPEND PY_PKG_LIST "pytest==7.4.3") | ||
| list(APPEND PY_PKG_LIST "h5py==3.11.0") | ||
| list(APPEND PY_PKG_LIST "cffi==1.16.0") |
Contributor
There was a problem hiding this comment.
It seems that all the versions between Python 3.8 and 3.10 are currently the same.
Was this intentional?
Contributor
Author
There was a problem hiding this comment.
yes, this PR is splitting for supporting two versions.
upcoming PRs will do modifications and add 12 and so on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will split python package list by python version 3.8 and 3.10.