Repository navigation
Keep state polls from overwriting newer edits and tab switches - #242
Merged
Merged
Conversation
Part of #228. A poll that left the browser before a tab switch or edit, or that is answered while that callback is still open, no longer writes sidebar controls or agent-state-store for that browser. In-flight sidebar drafts and the rename box stay as they were. Co-authored-by: Ming-Yu Guo <guomy26@mail2.sysu.edu.cn>
The fallback layout and the main layout both need the same hidden epoch, client id, and acknowledgement sink. One helper keeps the app factory within its line cap. Co-authored-by: Ming-Yu Guo <guomy26@mail2.sysu.edu.cn>
SchrodingersCattt
left a comment
Owner
Author
There was a problem hiding this comment.
Review @ 39305c28 (Part of #228)
Verdict: approve-ready pending remaining CI (COMMENT only; no self-APPROVE).
What looks right
- Covers the open high Latency checkbox after #226/#229: server-side scene + interaction-generation fence (
poll_request_is_stale/claim_poll_publish) plus browserpoll_fence.jsfor responses that race an in-flight tab switch/edit. - Pure poll vs batched tab-switch/upload distinction is clear; camera store left alone on the poll path; rename / in-flight sidebar drafts left as #226/#229.
- Wording avoids GitHub auto-close keywords for #163 (
does not address #163). - Focused tests in
tests/app/test_poll_interaction_fence.py; agent reported local1990 passed / 70 skipped.
CI at review time
5/9 green (build, bench smoke, fast×2, CPU smoke). Still running: Full tests 3.10/3.11/3.12 + Camera WebGL. Agent says WebGL path untouched — still wait for green before merge.
Hold
Do not squash-merge until all 9 checks are green. Figure-settle / busy-pill remains on #237.
This was referenced Oct 25, 2026
A generation of 0 is a real Dash callback. Treating it as absent counted that callback and never released it, so later edits left state polls blank for the rest of the page. Those polls copy a server projection onto the view radio and refresh the controls stamp. Part of #228. Co-authored-by: Ming-Yu Guo <guomy26@mail2.sysu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #228.
agent-state-pollcould still publish a snapshot that was frozen before the browser switched scenes or edited. Sidebar drafts already visible in that request stayed put (#229). Groups, transforms, polyhedra, selection, and the filled-scene guard did not.This covers the remaining high-severity checkbox on #228:
agent-state-pollraces user edits and tab switches (the rename box and in-flight sidebar path are already handled by #226 and #229).camera-state-storestays untouched on the poll path.This does not address #163. The figure-settle latency item on #228 remains.
Test plan
python3 -m pytest tests/app/test_poll_interaction_fence.pytests/app/test_camera_browser_regression.py,tests/app/test_real_app_browser_regression.py, andtests/app/test_layout_responsive.py— 25 passed, andtest_two_browsers_keep_separate_scenes_during_uploadpassed on a rerun after one isolated miss in the full local run.