-
Notifications
You must be signed in to change notification settings - Fork 23
fix: keep URLs intact when chunking LoRa replies #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Love4yzp
merged 2 commits into
Seeed-Solution:main
from
1Croydan1:fix/lora-chunking-urls
Jun 24, 2026
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // LoRa text payload is ~230 bytes per frame. The soft limit (textChunkLimit) | ||
| // keeps replies short; the hard limit is the most a single frame can carry. | ||
| export const MESHTASTIC_CHUNK_LIMIT = 200; | ||
| export const MESHTASTIC_HARD_LIMIT = 230; | ||
|
|
||
| /** | ||
| * Split a reply into LoRa-sized chunks without breaking words or URLs. | ||
| * | ||
| * Reflows on whitespace, packing tokens up to `limit`. A single token longer | ||
| * than `limit` (typically a URL) is kept whole up to the hard frame limit so | ||
| * links stay valid — it's only hard-split as a last resort when it cannot fit | ||
| * a single frame at all. The previous implementation broke at a fixed offset | ||
| * when no nearby space was found, which sliced long URLs in half and produced | ||
| * two unusable links. | ||
| */ | ||
| export function chunkText(text: string, limit: number): string[] { | ||
| const trimmed = text.trim(); | ||
| if (trimmed.length <= limit) { | ||
| return trimmed ? [trimmed] : []; | ||
| } | ||
|
|
||
| const hardMax = Math.max(limit, MESHTASTIC_HARD_LIMIT); | ||
|
|
||
| // Greedily pack whitespace-separated tokens, never splitting a token. | ||
| const packed: string[] = []; | ||
| let cur = ""; | ||
| for (const word of trimmed.split(/\s+/)) { | ||
| if (!word) continue; | ||
| if (cur === "") { | ||
| cur = word; | ||
| } else if (cur.length + 1 + word.length <= limit) { | ||
| cur += " " + word; | ||
| } else { | ||
| packed.push(cur); | ||
| cur = word; | ||
| } | ||
| } | ||
| if (cur) packed.push(cur); | ||
|
|
||
| // A packed entry may still be a single token longer than the soft limit | ||
| // (e.g. a URL). Keep it whole if it fits one frame; otherwise hard-split. | ||
| const chunks: string[] = []; | ||
| for (const entry of packed) { | ||
| if (entry.length <= hardMax) { | ||
| chunks.push(entry); | ||
| continue; | ||
| } | ||
| for (let i = 0; i < entry.length; i += hardMax) { | ||
| chunks.push(entry.slice(i, i + hardMax)); | ||
| } | ||
| } | ||
| return chunks; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.