3-5 New Charts - #6
Closed
ekoslow1-creator wants to merge 82 commits into
Closed
Conversation
Test PR for coolify
Documents the component architecture, live API integration (sefaria.org/api/powered-by), and the project_category data-quality handling agreed on during brainstorming. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The API's project_category field decomposes against 5 real form labels (one legacy naming variant) plus freeform "Other:" text - not the 6 categories shown on developers.sefaria.org as originally assumed. Verified by decomposing all 36 live entries with zero unmatched leftovers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…, screenshot URL validation) - screenshots.test.js: update the positive-case test to expect the real manifest path now that screenshotManifest.json is populated, and add a case covering the numeric id form used by ProjectCard.jsx - index.css: give has-screenshot cards their own hover background on the scrim pseudo-element so hovering isn't washed out by the 88%-opacity overlay - generate-screenshots.mjs: validate project_link before navigating to it, rejecting non-http(s) schemes and localhost/private/link-local hosts to close an SSRF/file-read path from unauthenticated submissions
… link, tags+desc on back)
The flip-card's hidden face was still hit-testable in the region behind the visible face's centered content (backface-visibility only affects painting, not pointer events), so clicking the center of a flipped-back card could trigger the hidden front title's link instead of unflipping. Scope pointer-events to whichever face is currently visible. Also add a hover color (var(--accent)) on the project title link, per request, as a visual affordance that it's clickable.
…ip-away on text selection, remove stale CSS - Add visibility: hidden alongside pointer-events: none on the flipped front face so the title link is removed from the tab order and accessibility tree while visually hidden. - Guard the card's click-to-flip handler against active text selections so releasing a text-selection drag inside the back-face description no longer flips the card away. - Remove stale position: relative on .project-card (no longer needed now that faces position against .project-card-inner). - Update stale comment on .project-card-desc to reflect the back-face layout (no image/title/link on that face anymore).
Extracts the six recharts blocks out of ChartsAndAnalytics.jsx into dedicated presentational components (one file per chart), each owning its chart-specific colors/constants. ChartsAndAnalytics.jsx now only handles data fetching/derivation and renders each chart with props. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
📊 Code Quality Score: 44/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
Collaborator
Author
|
Comments:
|
…ure/sc-46083/create-3-5-charts
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drops the manifest-driven local screenshot pipeline (generator script, public/screenshots/ images, screenshotManifest.json, getScreenshotUrl, and the ProjectCard background/hover CSS it drove) along with the puppeteer dependency it required. Screenshots are coming back later, backed by cloud storage instead of files committed to the repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…g, README, CSS Completes the previous commit, which only removed the screenshot files themselves. This drops the now-dead getScreenshotUrl import and background/hover CSS in ProjectCard, the puppeteer dependency and npm run screenshots script, and the README section documenting it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Replaces the literal hex colors in categories.js's CATEGORY_COLORS with references to the --chart-* palette already defined in index.css, so the category-color source of truth is the same palette the charts use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ekoslow1-creator
force-pushed
the
feature/sc-46083/create-3-5-charts
branch
from
August 5, 2026 11:25
36caea1 to
02ed0c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New charts for the dashboard
Replaces #4, which GitHub auto-closed and permanently locked after a history rewrite (removing a sensitive CSV) force-pushed the branch. Same content as #4, minus the CSV.