Skip to content

fix(shipgen): make tPythia6Generator concrete again (#1272) #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olantwin merged 1 commit into from
Jun 22, 2026
+9 −0
Merged

fix(shipgen): make tPythia6Generator concrete again (#1272) #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ it in future.

### Fixed

* Restore `tPythia6Generator` instantiation from Python — broken since 26.02 by the `SHiP::Generator` base-class refactor leaving the file-based `Init` overloads pure virtual without a stub override (#1272)

### Removed

## 26.06 - 2026-06-18
Expand Down
7 changes: 7 additions & 0 deletions shipgen/tPythia6Generator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include <utility>

#include "FairLogger.h"
#include "Generator.h"
#include "TPythia6.h"
#include "TPythia6Calls.h"
Expand All @@ -28,6 +29,12 @@ class tPythia6Generator : public SHiP::Generator {

using SHiP::Generator::Init;
Bool_t Init() override;
Bool_t Init(const char* inFile) override { return Init(inFile, 0); };
Bool_t Init(const char* inFile, int startEvent) override {
LOG(warning) << "Init with files not implemented for tPythia6Generator. "
"Using default Init() instead";
return Init();
};

void SetMom(Double_t mom) { fMom = mom; };
void SetTarget(TString Type, TString Target) {
Expand Down
Loading