Skip to content

Skip stale RBI file removal when --only is set #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaanOzkan merged 3 commits into from
Jun 8, 2026
+34 −0
Merged

Skip stale RBI file removal when --only is set #2642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4220c
Skip stale RBI file removal when `--only` is set
Vein05 Jun 7, 2026
a847648
Use direct file writes instead of tapioca dsl for test setup
Vein05 Jun 8, 2026
488ad63
Merge branch 'main' into fix/skip-purge-with-only
KaanOzkan Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/tapioca/commands/abstract_dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ def generate_dsl_rbi_files(outpath, quiet:)
)
end.compact

if @only.any?
say("Skipping stale RBI removal because `--only` is set.", :yellow)
return Set.new
end

files_to_purge = existing_rbi_files - generated_files

files_to_purge
Expand Down
29 changes: 29 additions & 0 deletions spec/tapioca/cli/dsl_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,6 +1311,7 @@ def self.gather_constants
Compiling DSL RBI files...

create sorbet/rbi/dsl/job.rbi
Skipping stale RBI removal because `--only` is set.

Done

Expand Down Expand Up @@ -1352,6 +1353,31 @@ module FooModule; end
assert_success_status(result)
end

it "does not remove existing RBI files when using --only" do
@project.write!("lib/job.rb", <<~RB)
require "sidekiq"

class Job
include Sidekiq::Worker
def perform(foo, bar)
end
end
RB

@project.write!("sorbet/rbi/dsl/post.rbi", "# typed: true\n")
@project.write!("sorbet/rbi/dsl/job.rbi", "# typed: true\n")

result = @project.tapioca("dsl --only SidekiqWorker")

assert_project_file_exist("sorbet/rbi/dsl/post.rbi")
assert_project_file_exist("sorbet/rbi/dsl/job.rbi")

assert_includes(result.out, "Skipping stale RBI removal because `--only` is set.")
refute_includes(result.out, "Removing stale RBI files")

assert_success_status(result)
end

it "warns if there are no matching compilers but continues processing" do
@project.write!("lib/post.rb", <<~RB)
require "smart_properties"
Expand All @@ -1373,6 +1399,7 @@ class Post
Warning: Cannot find compiler 'NonexistentCompiler'

create sorbet/rbi/dsl/post.rbi
Skipping stale RBI removal because `--only` is set.

Done

Expand Down Expand Up @@ -1941,6 +1968,7 @@ class Post < ActiveRecord::Base
Compiling DSL RBI files...

create sorbet/rbi/dsl/post.rbi
Skipping stale RBI removal because `--only` is set.

Done

Expand Down Expand Up @@ -3299,6 +3327,7 @@ class Post < ActiveRecord::Base
Compiling DSL RBI files...

create sorbet/rbi/dsl/post.rbi
Skipping stale RBI removal because `--only` is set.

Done

Expand Down
Loading