Add Ruby Liquid parity test suite for LiquidSyntaxError - #1268
Merged
Conversation
Scenario/snapshot corpus (36 tags, ~3600 cases) comparing LiquidSyntaxError detection against Ruby Liquid error output. Known detection gaps are listed in KNOWN_GAPS and asserted to still miss, so closing a gap fails the suite until the entry is removed. Run with PARITY_REPORT=1 to print a coverage summary.
karreiro
approved these changes
Aug 3, 2026
karreiro
left a comment
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this PR, @lukeh-shopify!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Migrate the Liquid parity test suite for LiquidSyntaxError to the public theme-check-common
What approach did you use?
Copies like-for-like, and ensures the test run in their new location